Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ASoC: apple: mca: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-24-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
eb5a9cf2 0e940c75

+2 -3
+2 -3
sound/soc/apple/mca.c
··· 1159 1159 return ret; 1160 1160 } 1161 1161 1162 - static int apple_mca_remove(struct platform_device *pdev) 1162 + static void apple_mca_remove(struct platform_device *pdev) 1163 1163 { 1164 1164 struct mca_data *mca = platform_get_drvdata(pdev); 1165 1165 1166 1166 snd_soc_unregister_component(&pdev->dev); 1167 1167 apple_mca_release(mca); 1168 - return 0; 1169 1168 } 1170 1169 1171 1170 static const struct of_device_id apple_mca_of_match[] = { ··· 1179 1180 .of_match_table = apple_mca_of_match, 1180 1181 }, 1181 1182 .probe = apple_mca_probe, 1182 - .remove = apple_mca_remove, 1183 + .remove_new = apple_mca_remove, 1183 1184 }; 1184 1185 module_platform_driver(apple_mca_driver); 1185 1186