Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

driver: base: pinctrl: return error from pinctrl_bind_pins()

strict pin controller returns -EINVAL in case of pin request which
is already claimed by somebody else.
Following is the sequence of calling pin_request() from
pinctrl_bind_pins():-
pinctrl_bind_pins()->pinctrl_select_state()->pinmux_enable_setting()->
pin_request()

But pinctrl_bind_pins() only returns -EPROBE_DEFER which makes device
driver probe successful even if the pin request is rejected by the pin
controller subsystem.

This commit modifies pinctrl_bind_pins() to return error if the pin is
rejected by pin control subsystem.

Signed-off-by: Deepak Das <deepak_das@mentor.com>
[Rewrote to be cleaner]
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Deepak and committed by
Linus Walleij
eb4ec68a 9b5fb0ca

+8 -4
+8 -4
drivers/base/pinctrl.c
··· 91 91 devm_kfree(dev, dev->pins); 92 92 dev->pins = NULL; 93 93 94 - /* Only return deferrals */ 95 - if (ret != -EPROBE_DEFER) 96 - ret = 0; 94 + /* Return deferrals */ 95 + if (ret == -EPROBE_DEFER) 96 + return ret; 97 + /* Return serious errors */ 98 + if (ret == -EINVAL) 99 + return ret; 100 + /* We ignore errors like -ENOENT meaning no pinctrl state */ 97 101 98 - return ret; 102 + return 0; 99 103 }