Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86/mce/AMD: Document some functionality

In an attempt to aid in understanding of what the threshold_block
structure holds, provide comments to describe the members here. Also,
trim comments around threshold_restart_bank() and update copyright info.

No functional change is introduced.

Signed-off-by: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
[ Shorten comments. ]
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/1457021458-2522-6-git-send-email-Aravind.Gopalakrishnan@amd.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>

authored by

Aravind Gopalakrishnan and committed by
Ingo Molnar
ea2ca36b 2cd3b5f9

+19 -14
+17 -9
arch/x86/include/asm/amd_nb.h
··· 27 27 }; 28 28 29 29 struct threshold_block { 30 - unsigned int block; 31 - unsigned int bank; 32 - unsigned int cpu; 33 - u32 address; 34 - u16 interrupt_enable; 35 - bool interrupt_capable; 36 - u16 threshold_limit; 37 - struct kobject kobj; 38 - struct list_head miscj; 30 + unsigned int block; /* Number within bank */ 31 + unsigned int bank; /* MCA bank the block belongs to */ 32 + unsigned int cpu; /* CPU which controls MCA bank */ 33 + u32 address; /* MSR address for the block */ 34 + u16 interrupt_enable; /* Enable/Disable APIC interrupt */ 35 + bool interrupt_capable; /* Bank can generate an interrupt. */ 36 + 37 + u16 threshold_limit; /* 38 + * Value upon which threshold 39 + * interrupt is generated. 40 + */ 41 + 42 + struct kobject kobj; /* sysfs object */ 43 + struct list_head miscj; /* 44 + * List of threshold blocks 45 + * within a bank. 46 + */ 39 47 }; 40 48 41 49 struct threshold_bank {
+2 -5
arch/x86/kernel/cpu/mcheck/mce_amd.c
··· 1 1 /* 2 - * (c) 2005-2015 Advanced Micro Devices, Inc. 2 + * (c) 2005-2016 Advanced Micro Devices, Inc. 3 3 * Your use of this code is subject to the terms and conditions of the 4 4 * GNU general public license version 2. See "COPYING" or 5 5 * http://www.gnu.org/licenses/gpl.html ··· 201 201 return 1; 202 202 }; 203 203 204 - /* 205 - * Called via smp_call_function_single(), must be called with correct 206 - * cpu affinity. 207 - */ 204 + /* Reprogram MCx_MISC MSR behind this threshold bank. */ 208 205 static void threshold_restart_bank(void *_tr) 209 206 { 210 207 struct thresh_restart *tr = _tr;