Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

genirq: fix off by one and coding style

Fix off-by-one in for_each_irq_desc_reverse().

Impact is near zero in practice, because nothing substantial wants to
iterate down to IRQ#0 - but fix it nevertheless.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

+5 -5
+2 -2
arch/x86/kernel/irq.c
··· 36 36 } 37 37 38 38 #ifdef CONFIG_X86_32 39 - # define irq_stats(x) (&per_cpu(irq_stat,x)) 39 + # define irq_stats(x) (&per_cpu(irq_stat, x)) 40 40 #else 41 41 # define irq_stats(x) cpu_pda(x) 42 42 #endif ··· 113 113 if (i == 0) { 114 114 seq_printf(p, " "); 115 115 for_each_online_cpu(j) 116 - seq_printf(p, "CPU%-8d",j); 116 + seq_printf(p, "CPU%-8d", j); 117 117 seq_putc(p, '\n'); 118 118 } 119 119
+3 -3
include/linux/irqnr.h
··· 13 13 # define for_each_irq_desc(irq, desc) \ 14 14 for (irq = 0, desc = irq_desc; irq < nr_irqs; irq++, desc++) 15 15 16 - # define for_each_irq_desc_reverse(irq, desc) \ 17 - for (irq = nr_irqs -1, desc = irq_desc + (nr_irqs -1 ); \ 18 - irq > 0; irq--, desc--) 16 + # define for_each_irq_desc_reverse(irq, desc) \ 17 + for (irq = nr_irqs - 1, desc = irq_desc + (nr_irqs - 1); \ 18 + irq >= 0; irq--, desc--) 19 19 #endif 20 20 21 21 #define for_each_irq_nr(irq) \