Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: fcoe: Memory leak fix in fcoe_sysfs_fcf_del()

In fcoe_sysfs_fcf_del(), we first deleted the fcf from the list and then
freed it if ctlr_dev was not NULL. This was causing a memory leak.

Free the fcf even if ctlr_dev is NULL.

Link: https://lore.kernel.org/r/20200729081824.30996-3-jhasan@marvell.com
Reviewed-by: Girish Basrur <gbasrur@marvell.com>
Reviewed-by: Santosh Vernekar <svernekar@marvell.com>
Reviewed-by: Saurav Kashyap <skashyap@marvell.com>
Reviewed-by: Shyam Sundar <ssundar@marvell.com>
Signed-off-by: Javed Hasan <jhasan@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Javed Hasan and committed by
Martin K. Petersen
e95b4789 a8ac7835

+1 -1
+1 -1
drivers/scsi/fcoe/fcoe_ctlr.c
··· 256 256 WARN_ON(!fcf_dev); 257 257 new->fcf_dev = NULL; 258 258 fcoe_fcf_device_delete(fcf_dev); 259 - kfree(new); 260 259 mutex_unlock(&cdev->lock); 261 260 } 261 + kfree(new); 262 262 } 263 263 264 264 /**