Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

samples/seccomp/Makefile: do not build tests if cross-compiling for MIPS

The Makefile is designed to use the host toolchain so it may be unsafe
to build the tests if the kernel has been configured and built for
another architecture. This fixes a build problem when the kernel has
been configured and built for the MIPS architecture but the host is not
MIPS (cross-compiled). The MIPS syscalls are only defined if one of the
following is true:

1) _MIPS_SIM == _MIPS_SIM_ABI64
2) _MIPS_SIM == _MIPS_SIM_ABI32
3) _MIPS_SIM == _MIPS_SIM_NABI32

Of course, none of these make sense on a non-MIPS toolchain and the
following build problem occurs when building on a non-MIPS host.

linux/usr/include/linux/kexec.h:50: userspace cannot reference function or variable defined in the kernel
samples/seccomp/bpf-direct.c: In function `emulator':
samples/seccomp/bpf-direct.c:76:17: error: `__NR_write' undeclared (first use in this function)

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Reported-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Markos Chandras and committed by
Linus Torvalds
e9107f88 a5ed3cee

+10 -4
+10 -4
samples/seccomp/Makefile
··· 18 18 bpf-direct-objs := bpf-direct.o 19 19 20 20 # Try to match the kernel target. 21 - ifndef CONFIG_64BIT 22 21 ifndef CROSS_COMPILE 22 + ifndef CONFIG_64BIT 23 23 24 24 # s390 has -m31 flag to build 31 bit binaries 25 25 ifndef CONFIG_S390 ··· 36 36 HOSTLOADLIBES_bpf-fancy += $(MFLAG) 37 37 HOSTLOADLIBES_dropper += $(MFLAG) 38 38 endif 39 - endif 40 - 41 - # Tell kbuild to always build the programs 42 39 always := $(hostprogs-y) 40 + else 41 + # MIPS system calls are defined based on the -mabi that is passed 42 + # to the toolchain which may or may not be a valid option 43 + # for the host toolchain. So disable tests if target architecture 44 + # is MIPS but the host isn't. 45 + ifndef CONFIG_MIPS 46 + always := $(hostprogs-y) 47 + endif 48 + endif