Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: lola: Remove unused lola_(save|restore)_mixer

lola_restore_mixer() and lola_save_mixer() were added in 2011 by
commit d43f3010b8fa ("ALSA: Add the driver for Digigram Lola
PCI-e boards")
but have remain unused.

Remove them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Link: https://patch.msgid.link/20250122022059.456068-1-linux@treblig.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>

authored by

Dr. David Alan Gilbert and committed by
Takashi Iwai
e8d04a92 76b0a22d

-45
-2
sound/pci/lola/lola.h
··· 499 499 void lola_free_mixer(struct lola *chip); 500 500 int lola_create_mixer(struct lola *chip); 501 501 int lola_setup_all_analog_gains(struct lola *chip, int dir, bool mute); 502 - void lola_save_mixer(struct lola *chip); 503 - void lola_restore_mixer(struct lola *chip); 504 502 int lola_set_src_config(struct lola *chip, unsigned int src_mask, bool update); 505 503 506 504 /* proc */
-43
sound/pci/lola/lola_mixer.c
··· 336 336 return lola_codec_flush(chip); 337 337 } 338 338 339 - void lola_save_mixer(struct lola *chip) 340 - { 341 - /* mute analog output */ 342 - if (chip->mixer.array_saved) { 343 - /* store contents of mixer array */ 344 - memcpy_fromio(chip->mixer.array_saved, chip->mixer.array, 345 - sizeof(*chip->mixer.array)); 346 - } 347 - lola_setup_all_analog_gains(chip, PLAY, true); /* output mute */ 348 - } 349 - 350 - void lola_restore_mixer(struct lola *chip) 351 - { 352 - int i; 353 - 354 - /*lola_reset_setups(chip);*/ 355 - if (chip->mixer.array_saved) { 356 - /* restore contents of mixer array */ 357 - memcpy_toio(chip->mixer.array, chip->mixer.array_saved, 358 - sizeof(*chip->mixer.array)); 359 - /* inform micro-controller about all restored values 360 - * and ignore return values 361 - */ 362 - for (i = 0; i < chip->mixer.src_phys_ins; i++) 363 - lola_codec_write(chip, chip->mixer.nid, 364 - LOLA_VERB_SET_SOURCE_GAIN, 365 - i, 0); 366 - for (i = 0; i < chip->mixer.src_stream_outs; i++) 367 - lola_codec_write(chip, chip->mixer.nid, 368 - LOLA_VERB_SET_SOURCE_GAIN, 369 - chip->mixer.src_stream_out_ofs + i, 0); 370 - for (i = 0; i < chip->mixer.dest_stream_ins; i++) 371 - lola_codec_write(chip, chip->mixer.nid, 372 - LOLA_VERB_SET_DESTINATION_GAIN, 373 - i, 0); 374 - for (i = 0; i < chip->mixer.dest_phys_outs; i++) 375 - lola_codec_write(chip, chip->mixer.nid, 376 - LOLA_VERB_SET_DESTINATION_GAIN, 377 - chip->mixer.dest_phys_out_ofs + i, 0); 378 - lola_codec_flush(chip); 379 - } 380 - } 381 - 382 339 /* 383 340 */ 384 341