Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers: fix dma_get_required_mask

There's a bug in the current implementation of dma_get_required_mask()
where it ands the returned mask with the current device mask. This
rather defeats the purpose if you're using the call to determine what
your mask should be (since you will at that time have the default
DMA_32BIT_MASK). This bug results in any driver that uses this function
*always* getting a 32 bit mask, which is wrong.

Fix by removing the and with dev->dma_mask.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>


authored by

James Bottomley and committed by
Greg Kroah-Hartman
e88a0c2c fbab976d

+1 -1
+1 -1
drivers/base/platform.c
··· 648 648 high_totalram += high_totalram - 1; 649 649 mask = (((u64)high_totalram) << 32) + 0xffffffff; 650 650 } 651 - return mask & *dev->dma_mask; 651 + return mask; 652 652 } 653 653 EXPORT_SYMBOL_GPL(dma_get_required_mask); 654 654 #endif