Revert "SUNRPC: Fail faster on bad verifier"

This reverts commit 0701214cd6e66585a999b132eb72ae0489beb724.

The premise of this commit was incorrect. There are exactly 2 cases
where rpcauth_checkverf() will return an error:

1) If there was an XDR decode problem (i.e. garbage data).
2) If gss_validate() had a problem verifying the RPCSEC_GSS MIC.

In the second case, there are again 2 subcases:

a) The GSS context expires, in which case gss_validate() will force a
new context negotiation on retry by invalidating the cred.
b) The sequence number check failed because an RPC call timed out, and
the client retransmitted the request using a new sequence number,
as required by RFC2203.

In neither subcase is this a fatal error.

Reported-by: Russell Cattelan <[e-mail]>
Fixes: 0701214cd6e6 ("SUNRPC: Fail faster on bad verifier")
Cc: [e-mail]
Signed-off-by: Trond Myklebust <[e-mail]>
Signed-off-by: Anna Schumaker <[e-mail]>

net/sunrpc/clnt.c

···
 
 out_verifier:
 	trace_rpc_bad_verifier(task);
-	goto out_err;
+	goto out_garbage;
 
 out_msg_denied:
 	error = -EACCES;