Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PM: sleep: wakeirq: drop unused enable helpers

Drop the wake-irq enable and disable helpers which have not been used
since commit bed570307ed7 ("PM / wakeirq: Fix dedicated wakeirq for
drivers not using autosuspend").

Note that these functions are essentially just leftovers from the first
iteration of the wake-irq implementation where device drivers were
supposed to call these functions themselves instead of PM core (as
is also indicated by the bogus kernel doc comments).

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

authored by

Johan Hovold and committed by
Rafael J. Wysocki
e7b91521 8527beb1

-59
-49
drivers/base/power/wakeirq.c
··· 194 194 return err; 195 195 } 196 196 197 - 198 197 /** 199 198 * dev_pm_set_dedicated_wake_irq - Request a dedicated wake-up interrupt 200 199 * @dev: Device entry ··· 205 206 * Sets up a threaded interrupt handler for a device that has 206 207 * a dedicated wake-up interrupt in addition to the device IO 207 208 * interrupt. 208 - * 209 - * The interrupt starts disabled, and needs to be managed for 210 - * the device by the bus code or the device driver using 211 - * dev_pm_enable_wake_irq*() and dev_pm_disable_wake_irq*() 212 - * functions. 213 209 */ 214 210 int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq) 215 211 { ··· 226 232 * the status of WAKE_IRQ_DEDICATED_REVERSE to tell rpm_suspend() 227 233 * to enable dedicated wake-up interrupt after running the runtime suspend 228 234 * callback for @dev. 229 - * 230 - * The interrupt starts disabled, and needs to be managed for 231 - * the device by the bus code or the device driver using 232 - * dev_pm_enable_wake_irq*() and dev_pm_disable_wake_irq*() 233 - * functions. 234 235 */ 235 236 int dev_pm_set_dedicated_wake_irq_reverse(struct device *dev, int irq) 236 237 { 237 238 return __dev_pm_set_dedicated_wake_irq(dev, irq, WAKE_IRQ_DEDICATED_REVERSE); 238 239 } 239 240 EXPORT_SYMBOL_GPL(dev_pm_set_dedicated_wake_irq_reverse); 240 - 241 - /** 242 - * dev_pm_enable_wake_irq - Enable device wake-up interrupt 243 - * @dev: Device 244 - * 245 - * Optionally called from the bus code or the device driver for 246 - * runtime_resume() to override the PM runtime core managed wake-up 247 - * interrupt handling to enable the wake-up interrupt. 248 - * 249 - * Note that for runtime_suspend()) the wake-up interrupts 250 - * should be unconditionally enabled unlike for suspend() 251 - * that is conditional. 252 - */ 253 - void dev_pm_enable_wake_irq(struct device *dev) 254 - { 255 - struct wake_irq *wirq = dev->power.wakeirq; 256 - 257 - if (wirq && (wirq->status & WAKE_IRQ_DEDICATED_ALLOCATED)) 258 - enable_irq(wirq->irq); 259 - } 260 - EXPORT_SYMBOL_GPL(dev_pm_enable_wake_irq); 261 - 262 - /** 263 - * dev_pm_disable_wake_irq - Disable device wake-up interrupt 264 - * @dev: Device 265 - * 266 - * Optionally called from the bus code or the device driver for 267 - * runtime_suspend() to override the PM runtime core managed wake-up 268 - * interrupt handling to disable the wake-up interrupt. 269 - */ 270 - void dev_pm_disable_wake_irq(struct device *dev) 271 - { 272 - struct wake_irq *wirq = dev->power.wakeirq; 273 - 274 - if (wirq && (wirq->status & WAKE_IRQ_DEDICATED_ALLOCATED)) 275 - disable_irq_nosync(wirq->irq); 276 - } 277 - EXPORT_SYMBOL_GPL(dev_pm_disable_wake_irq); 278 241 279 242 /** 280 243 * dev_pm_enable_wake_irq_check - Checks and enables wake-up interrupt
-10
include/linux/pm_wakeirq.h
··· 10 10 extern int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq); 11 11 extern int dev_pm_set_dedicated_wake_irq_reverse(struct device *dev, int irq); 12 12 extern void dev_pm_clear_wake_irq(struct device *dev); 13 - extern void dev_pm_enable_wake_irq(struct device *dev); 14 - extern void dev_pm_disable_wake_irq(struct device *dev); 15 13 16 14 #else /* !CONFIG_PM */ 17 15 ··· 29 31 } 30 32 31 33 static inline void dev_pm_clear_wake_irq(struct device *dev) 32 - { 33 - } 34 - 35 - static inline void dev_pm_enable_wake_irq(struct device *dev) 36 - { 37 - } 38 - 39 - static inline void dev_pm_disable_wake_irq(struct device *dev) 40 34 { 41 35 } 42 36