Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Revert "drm/vmwgfx: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()"

This reverts commit 6b92e77156c5adf6606c8ad825c71404417d88af.

This patchset breaks on intel platforms and was previously NACK'd by
Ville.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Fernando Ramos <greenfoo@u92.eu>
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20211002154542.15800-12-sean@poorly.run

+8 -15
+4 -7
drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
··· 28 28 #include "vmwgfx_drv.h" 29 29 #include "vmwgfx_devcaps.h" 30 30 #include <drm/vmwgfx_drm.h> 31 - #include <drm/drm_drv.h> 32 31 #include "vmwgfx_kms.h" 33 32 34 33 int vmw_getparam_ioctl(struct drm_device *dev, void *data, ··· 172 173 struct drm_vmw_rect __user *clips_ptr; 173 174 struct drm_vmw_rect *clips = NULL; 174 175 struct drm_framebuffer *fb; 175 - struct drm_modeset_acquire_ctx ctx; 176 176 struct vmw_framebuffer *vfb; 177 177 struct vmw_resource *res; 178 178 uint32_t num_clips; ··· 203 205 goto out_no_copy; 204 206 } 205 207 206 - DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, 0, ret); 208 + drm_modeset_lock_all(dev); 207 209 208 210 fb = drm_framebuffer_lookup(dev, file_priv, arg->fb_id); 209 211 if (!fb) { ··· 231 233 out_no_surface: 232 234 drm_framebuffer_put(fb); 233 235 out_no_fb: 234 - DRM_MODESET_LOCK_ALL_END(dev, ctx, ret); 236 + drm_modeset_unlock_all(dev); 235 237 out_no_copy: 236 238 kfree(clips); 237 239 out_clips: ··· 250 252 struct drm_vmw_rect __user *clips_ptr; 251 253 struct drm_vmw_rect *clips = NULL; 252 254 struct drm_framebuffer *fb; 253 - struct drm_modeset_acquire_ctx ctx; 254 255 struct vmw_framebuffer *vfb; 255 256 uint32_t num_clips; 256 257 int ret; ··· 280 283 goto out_no_copy; 281 284 } 282 285 283 - DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, 0, ret); 286 + drm_modeset_lock_all(dev); 284 287 285 288 fb = drm_framebuffer_lookup(dev, file_priv, arg->fb_id); 286 289 if (!fb) { ··· 303 306 out_no_ttm_lock: 304 307 drm_framebuffer_put(fb); 305 308 out_no_fb: 306 - DRM_MODESET_LOCK_ALL_END(dev, ctx, ret); 309 + drm_modeset_unlock_all(dev); 307 310 out_no_copy: 308 311 kfree(clips); 309 312 out_clips:
+4 -8
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
··· 33 33 #include <drm/drm_rect.h> 34 34 #include <drm/drm_sysfs.h> 35 35 #include <drm/drm_vblank.h> 36 - #include <drm/drm_drv.h> 37 36 38 37 #include "vmwgfx_kms.h" 39 38 ··· 243 244 struct drm_device *dev = &dev_priv->drm; 244 245 struct vmw_display_unit *du; 245 246 struct drm_crtc *crtc; 246 - struct drm_modeset_acquire_ctx ctx; 247 - int ret; 248 247 249 - DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, 0, ret); 248 + drm_modeset_lock_all(dev); 250 249 drm_for_each_crtc(crtc, dev) { 251 250 du = vmw_crtc_to_du(crtc); 252 251 253 252 du->hotspot_x = 0; 254 253 du->hotspot_y = 0; 255 254 } 256 - DRM_MODESET_LOCK_ALL_END(dev, ctx, ret); 255 + drm_modeset_unlock_all(dev); 257 256 } 258 257 259 258 void vmw_kms_cursor_post_execbuf(struct vmw_private *dev_priv) ··· 1012 1015 struct vmw_framebuffer_bo *vfbd = 1013 1016 vmw_framebuffer_to_vfbd(framebuffer); 1014 1017 struct drm_clip_rect norect; 1015 - struct drm_modeset_acquire_ctx ctx; 1016 1018 int ret, increment = 1; 1017 1019 1018 - DRM_MODESET_LOCK_ALL_BEGIN((&dev_priv->drm), ctx, 0, ret); 1020 + drm_modeset_lock_all(&dev_priv->drm); 1019 1021 1020 1022 if (!num_clips) { 1021 1023 num_clips = 1; ··· 1040 1044 1041 1045 vmw_cmd_flush(dev_priv, false); 1042 1046 1043 - DRM_MODESET_LOCK_ALL_END((&dev_priv->drm), ctx, ret); 1047 + drm_modeset_unlock_all(&dev_priv->drm); 1044 1048 1045 1049 return ret; 1046 1050 }