Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Revert "drm/amd/display: Unblank hubp based on plane visibility"

This reverts commit fd1c85d3ac2ccfec33b007399e6677b41899a888

[Why]
We are not implementing the planned new HW sequence
to disable HUBP.

[How]
Revert most related changes to minimize possibility
of regression.

Signed-off-by: Wesley Chalmers <Wesley.Chalmers@amd.com>
Reviewed-by: Martin Leung <Martin.Leung@amd.com>
Acked-by: Qingqing Zhuo <Qingqing.Zhuo@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Wesley Chalmers and committed by
Alex Deucher
e7a30ade 29249676

+9 -17
+6 -14
drivers/gpu/drm/amd/display/dc/basics/dc_common.c
··· 49 49 } 50 50 } 51 51 52 - bool is_child_pipe_tree_visible(struct pipe_ctx *pipe_ctx) 52 + bool is_lower_pipe_tree_visible(struct pipe_ctx *pipe_ctx) 53 53 { 54 54 if (pipe_ctx->plane_state && pipe_ctx->plane_state->visible) 55 55 return true; 56 - if (pipe_ctx->bottom_pipe && is_child_pipe_tree_visible(pipe_ctx->bottom_pipe)) 57 - return true; 58 - if (pipe_ctx->next_odm_pipe && is_child_pipe_tree_visible(pipe_ctx->next_odm_pipe)) 56 + if (pipe_ctx->bottom_pipe && is_lower_pipe_tree_visible(pipe_ctx->bottom_pipe)) 59 57 return true; 60 58 return false; 61 59 } 62 60 63 - bool is_parent_pipe_tree_visible(struct pipe_ctx *pipe_ctx) 61 + bool is_upper_pipe_tree_visible(struct pipe_ctx *pipe_ctx) 64 62 { 65 63 if (pipe_ctx->plane_state && pipe_ctx->plane_state->visible) 66 64 return true; 67 - if (pipe_ctx->top_pipe && is_parent_pipe_tree_visible(pipe_ctx->top_pipe)) 68 - return true; 69 - if (pipe_ctx->prev_odm_pipe && is_parent_pipe_tree_visible(pipe_ctx->prev_odm_pipe)) 65 + if (pipe_ctx->top_pipe && is_upper_pipe_tree_visible(pipe_ctx->top_pipe)) 70 66 return true; 71 67 return false; 72 68 } ··· 71 75 { 72 76 if (pipe_ctx->plane_state && pipe_ctx->plane_state->visible) 73 77 return true; 74 - if (pipe_ctx->top_pipe && is_parent_pipe_tree_visible(pipe_ctx->top_pipe)) 78 + if (pipe_ctx->top_pipe && is_upper_pipe_tree_visible(pipe_ctx->top_pipe)) 75 79 return true; 76 - if (pipe_ctx->bottom_pipe && is_child_pipe_tree_visible(pipe_ctx->bottom_pipe)) 77 - return true; 78 - if (pipe_ctx->prev_odm_pipe && is_parent_pipe_tree_visible(pipe_ctx->prev_odm_pipe)) 79 - return true; 80 - if (pipe_ctx->next_odm_pipe && is_child_pipe_tree_visible(pipe_ctx->next_odm_pipe)) 80 + if (pipe_ctx->bottom_pipe && is_lower_pipe_tree_visible(pipe_ctx->bottom_pipe)) 81 81 return true; 82 82 return false; 83 83 }
+2 -2
drivers/gpu/drm/amd/display/dc/basics/dc_common.h
··· 30 30 31 31 bool is_rgb_cspace(enum dc_color_space output_color_space); 32 32 33 - bool is_child_pipe_tree_visible(struct pipe_ctx *pipe_ctx); 33 + bool is_lower_pipe_tree_visible(struct pipe_ctx *pipe_ctx); 34 34 35 - bool is_parent_pipe_tree_visible(struct pipe_ctx *pipe_ctx); 35 + bool is_upper_pipe_tree_visible(struct pipe_ctx *pipe_ctx); 36 36 37 37 bool is_pipe_tree_visible(struct pipe_ctx *pipe_ctx); 38 38
+1 -1
drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c
··· 1575 1575 1576 1576 1577 1577 1578 - if (is_pipe_tree_visible(pipe_ctx)) 1578 + if (pipe_ctx->update_flags.bits.enable) 1579 1579 dc->hwss.set_hubp_blank(dc, pipe_ctx, false); 1580 1580 } 1581 1581