Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mfd: twl4030-power: Simplify error path

Remove unnecessary goto statements, causing duplicated if
conditions.

Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

authored by

Florian Vaussard and committed by
Samuel Ortiz
e77a4c2f b0fc1da4

+15 -23
+15 -23
drivers/mfd/twl4030-power.c
··· 567 567 568 568 err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, TWL4030_PM_MASTER_KEY_CFG1, 569 569 TWL4030_PM_MASTER_PROTECT_KEY); 570 - if (err) 571 - goto unlock; 572 - 573 - err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, TWL4030_PM_MASTER_KEY_CFG2, 570 + err |= twl_i2c_write_u8(TWL_MODULE_PM_MASTER, 571 + TWL4030_PM_MASTER_KEY_CFG2, 574 572 TWL4030_PM_MASTER_PROTECT_KEY); 575 - if (err) 576 - goto unlock; 573 + 574 + if (err) { 575 + pr_err("TWL4030 Unable to unlock registers\n"); 576 + return err; 577 + } 577 578 578 579 if (pdata) { 579 580 /* TODO: convert to device tree */ 580 581 err = twl4030_power_configure_scripts(pdata); 581 - if (err) 582 - goto load; 582 + if (err) { 583 + pr_err("TWL4030 failed to load scripts\n"); 584 + return err; 585 + } 583 586 err = twl4030_power_configure_resources(pdata); 584 - if (err) 585 - goto resource; 587 + if (err) { 588 + pr_err("TWL4030 failed to configure resource\n"); 589 + return err; 590 + } 586 591 } 587 592 588 593 /* Board has to be wired properly to use this feature */ ··· 616 611 TWL4030_PM_MASTER_PROTECT_KEY); 617 612 if (err) 618 613 pr_err("TWL4030 Unable to relock registers\n"); 619 - return err; 620 - 621 - unlock: 622 - if (err) 623 - pr_err("TWL4030 Unable to unlock registers\n"); 624 - return err; 625 - load: 626 - if (err) 627 - pr_err("TWL4030 failed to load scripts\n"); 628 - return err; 629 - resource: 630 - if (err) 631 - pr_err("TWL4030 failed to configure resource\n"); 632 614 return err; 633 615 } 634 616