Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

lib: test_objagg: Set error message in check_expect_hints_stats()

Smatch complains that the error message isn't set in the caller:

lib/test_objagg.c:923 test_hints_case2()
error: uninitialized symbol 'errmsg'.

This static checker warning only showed up after a recent refactoring
but the bug dates back to when the code was originally added. This
likely doesn't affect anything in real life.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202506281403.DsuyHFTZ-lkp@intel.com/
Fixes: 0a020d416d0a ("lib: introduce initial implementation of object aggregation manager")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/8548f423-2e3b-4bb7-b816-5041de2762aa@sabinyo.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Dan Carpenter and committed by
Jakub Kicinski
e6ed134a 72fb8373

+3 -1
+3 -1
lib/test_objagg.c
··· 899 899 int err; 900 900 901 901 stats = objagg_hints_stats_get(objagg_hints); 902 - if (IS_ERR(stats)) 902 + if (IS_ERR(stats)) { 903 + *errmsg = "objagg_hints_stats_get() failed."; 903 904 return PTR_ERR(stats); 905 + } 904 906 err = __check_expect_stats(stats, expect_stats, errmsg); 905 907 objagg_stats_put(stats); 906 908 return err;