Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

regulator: act8865: Remove "too many regulators" error handler

The check would dereference pdata, which can be NULL in the non-DT
use case.

Nothing will break if pdata->num_regulators is larger than the number
of regulators that the driver defines: pdata->num_regulators is only
read in act8865_get_init_data() to iterate through pdata->regulators.

The error handler might have some value as a sanity check on the
platform data, but the platform data could be broken in many other
ways that are not checked for (unknown IDs, duplicate IDs), so I see
no reason to perform only this specific check.

Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Maarten ter Huurne and committed by
Mark Brown
e6e79fd9 de14ba67

-6
-6
drivers/regulator/act8865-regulator.c
··· 485 485 pdata = &pdata_of; 486 486 } 487 487 488 - if (pdata->num_regulators > num_regulators) { 489 - dev_err(dev, "too many regulators: %d\n", 490 - pdata->num_regulators); 491 - return -EINVAL; 492 - } 493 - 494 488 act8865 = devm_kzalloc(dev, sizeof(struct act8865), GFP_KERNEL); 495 489 if (!act8865) 496 490 return -ENOMEM;