Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev: omapfb: delete check_required_callbacks()

Commit 561eb9d09a93 ("fbdev: omap/lcd: Make callbacks optional") made
panel callbacks optional but forgot to update check_required_callbacks().
As a result many (all?) OMAP systems using omapfb will crash at boot.
Fix by deleting the whole function.

Fixes: 561eb9d09a93 ("fbdev: omap/lcd: Make callbacks optional")
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

authored by

Aaro Koskinen and committed by
Bartlomiej Zolnierkiewicz
e68d490d 9121b15b

-15
-15
drivers/video/fbdev/omap/omapfb_main.c
··· 1608 1608 return 0; 1609 1609 } 1610 1610 1611 - static void check_required_callbacks(struct omapfb_device *fbdev) 1612 - { 1613 - #define _C(x) (fbdev->ctrl->x != NULL) 1614 - #define _P(x) (fbdev->panel->x != NULL) 1615 - BUG_ON(fbdev->ctrl == NULL || fbdev->panel == NULL); 1616 - BUG_ON(!(_C(init) && _C(cleanup) && _C(get_caps) && 1617 - _C(set_update_mode) && _C(setup_plane) && _C(enable_plane) && 1618 - _P(init) && _P(cleanup) && _P(enable) && _P(disable) && 1619 - _P(get_caps))); 1620 - #undef _P 1621 - #undef _C 1622 - } 1623 - 1624 1611 /* 1625 1612 * Called by LDM binding to probe and attach a new device. 1626 1613 * Initialization sequence: ··· 1691 1704 if (fbdev->ctrl->mmap != NULL) 1692 1705 omapfb_ops.fb_mmap = omapfb_mmap; 1693 1706 init_state++; 1694 - 1695 - check_required_callbacks(fbdev); 1696 1707 1697 1708 r = planes_init(fbdev); 1698 1709 if (r)