selftests: Clean forgotten resources as part of cleanup()

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

Several tests do not set some ports down as part of their cleanup(),
resulting in IPv6 link-local addresses and associated routes not being
deleted.

These leaks were found using a BPF tool that monitors ASIC resources.

Solve this by setting the ports down at the end of the tests.

Signed-off-by: Amit Cohen <amcohen@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Amit Cohen and committed by

David S. Miller 4 years ago e67dfb8d 00190c2b

+14

6 changed files

expand all

tools

testing

selftests

drivers

net

mlxsw

devlink_trap_l3_drops.sh

devlink_trap_l3_exceptions.sh

qos_dscp_bridge.sh

net

forwarding

pedit_dsfield.sh

pedit_l4port.sh

skbedit_priority.sh

tools/testing/selftests/drivers/net/mlxsw/devlink_trap_l3_drops.sh

··· 109 109 __addr_add_del $rp1 del 192.0.2.2/24 2001:db8:1::2/64 110 110 111 111 tc qdisc del dev $rp2 clsact 112 + 113 + ip link set dev $rp2 down 114 + ip link set dev $rp1 down 112 115 } 113 116 114 117 setup_prepare()

tools/testing/selftests/drivers/net/mlxsw/devlink_trap_l3_exceptions.sh

··· 111 111 __addr_add_del $rp1 del 192.0.2.2/24 2001:db8:1::2/64 112 112 113 113 tc qdisc del dev $rp2 clsact 114 + 115 + ip link set dev $rp2 down 116 + ip link set dev $rp1 down 114 117 } 115 118 116 119 setup_prepare()

tools/testing/selftests/drivers/net/mlxsw/qos_dscp_bridge.sh

··· 93 93 lldptool -T -i $swp1 -V APP -d $(dscp_map 10) >/dev/null 94 94 lldpad_app_wait_del 95 95 96 + ip link set dev $swp2 down 96 97 ip link set dev $swp2 nomaster 98 + ip link set dev $swp1 down 97 99 ip link set dev $swp1 nomaster 98 100 ip link del dev br1 99 101 }

tools/testing/selftests/net/forwarding/pedit_dsfield.sh

··· 75 75 tc qdisc del dev $swp2 clsact 76 76 tc qdisc del dev $swp1 clsact 77 77 78 + ip link set dev $swp2 down 78 79 ip link set dev $swp2 nomaster 80 + ip link set dev $swp1 down 79 81 ip link set dev $swp1 nomaster 80 82 ip link del dev br1 81 83 }

tools/testing/selftests/net/forwarding/pedit_l4port.sh

··· 71 71 tc qdisc del dev $swp2 clsact 72 72 tc qdisc del dev $swp1 clsact 73 73 74 + ip link set dev $swp2 down 74 75 ip link set dev $swp2 nomaster 76 + ip link set dev $swp1 down 75 77 ip link set dev $swp1 nomaster 76 78 ip link del dev br1 77 79 }

tools/testing/selftests/net/forwarding/skbedit_priority.sh

··· 72 72 tc qdisc del dev $swp2 clsact 73 73 tc qdisc del dev $swp1 clsact 74 74 75 + ip link set dev $swp2 down 75 76 ip link set dev $swp2 nomaster 77 + ip link set dev $swp1 down 76 78 ip link set dev $swp1 nomaster 77 79 ip link del dev br1 78 80 }