Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

MIPS: KVM: Use prandom_u32_max() to generate tlbwr index

Emulation of the tlbwr instruction, which writes a TLB entry to a random
index in the TLB, currently uses get_random_bytes() to generate a 4 byte
random number which we then mask to form the index. This is overkill in
a couple of ways:

- We don't need 4 bytes here since we mask the value to form a 6 bit
number anyway, so we waste /dev/random entropy generating 3 random
bytes that are unused.

- We don't need crypto-grade randomness here - the architecture spec
allows implementations to use any algorithm & merely encourages that
some pseudo-randomness be used rather than a simple counter. The
fast prandom_u32() function fits that criteria well.

So rather than using get_random_bytes() & consuming /dev/random entropy,
switch to using the faster prandom_u32_max() which provides what we need
here whilst also performing the masking/modulo for us.

Signed-off-by: Paul Burton <paul.burton@mips.com>
Reported-by: George Spelvin <lkml@sdf.org>
Cc: James Hogan <jhogan@kernel.org>
Cc: linux-mips@vger.kernel.org

+1 -3
+1 -3
arch/mips/kvm/emulate.c
··· 1141 1141 unsigned long pc = vcpu->arch.pc; 1142 1142 int index; 1143 1143 1144 - get_random_bytes(&index, sizeof(index)); 1145 - index &= (KVM_MIPS_GUEST_TLB_SIZE - 1); 1146 - 1144 + index = prandom_u32_max(KVM_MIPS_GUEST_TLB_SIZE); 1147 1145 tlb = &vcpu->arch.guest_tlb[index]; 1148 1146 1149 1147 kvm_mips_invalidate_guest_tlb(vcpu, tlb);