Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

i2c: Drop I2C_CLIENT_INSMOD_2 to 8

These macros simply declare an enum, so drivers might as well declare
it themselves. This puts an end to the arbitrary limit of 8 chip types
per i2c driver.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Tested-by: Wolfram Sang <w.sang@pengutronix.de>

+26 -75
+2 -3
drivers/hwmon/adm1021.c
··· 34 34 static const unsigned short normal_i2c[] = { 35 35 0x18, 0x19, 0x1a, 0x29, 0x2a, 0x2b, 0x4c, 0x4d, 0x4e, I2C_CLIENT_END }; 36 36 37 - /* Insmod parameters */ 38 - I2C_CLIENT_INSMOD_8(adm1021, adm1023, max1617, max1617a, thmc10, lm84, gl523sm, 39 - mc1066); 37 + enum chips { 38 + adm1021, adm1023, max1617, max1617a, thmc10, lm84, gl523sm, mc1066 }; 40 39 41 40 /* adm1021 constants specified below */ 42 41
+1 -5
drivers/hwmon/adm1025.c
··· 64 64 65 65 static const unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END }; 66 66 67 - /* 68 - * Insmod parameters 69 - */ 70 - 71 - I2C_CLIENT_INSMOD_2(adm1025, ne1619); 67 + enum chips { adm1025, ne1619 }; 72 68 73 69 /* 74 70 * The ADM1025 registers
+1 -2
drivers/hwmon/adm1031.c
··· 64 64 /* Addresses to scan */ 65 65 static const unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END }; 66 66 67 - /* Insmod parameters */ 68 - I2C_CLIENT_INSMOD_2(adm1030, adm1031); 67 + enum chips { adm1030, adm1031 }; 69 68 70 69 typedef u8 auto_chan_table_t[8][2]; 71 70
+1 -2
drivers/hwmon/adm9240.c
··· 55 55 static const unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, 0x2f, 56 56 I2C_CLIENT_END }; 57 57 58 - /* Insmod parameters */ 59 - I2C_CLIENT_INSMOD_3(adm9240, ds1780, lm81); 58 + enum chips { adm9240, ds1780, lm81 }; 60 59 61 60 /* ADM9240 registers */ 62 61 #define ADM9240_REG_MAN_ID 0x3e
+1 -1
drivers/hwmon/adt7475.c
··· 148 148 149 149 static unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END }; 150 150 151 - I2C_CLIENT_INSMOD_4(adt7473, adt7475, adt7476, adt7490); 151 + enum chips { adt7473, adt7475, adt7476, adt7490 }; 152 152 153 153 static const struct i2c_device_id adt7475_id[] = { 154 154 { "adt7473", adt7473 },
+1 -5
drivers/hwmon/dme1737.c
··· 57 57 /* Addresses to scan */ 58 58 static const unsigned short normal_i2c[] = {0x2c, 0x2d, 0x2e, I2C_CLIENT_END}; 59 59 60 - /* Insmod parameters */ 61 - I2C_CLIENT_INSMOD_2(dme1737, sch5027); 62 - 63 - /* ISA chip types */ 64 - enum isa_chips { sch311x = sch5027 + 1 }; 60 + enum chips { dme1737, sch5027, sch311x }; 65 61 66 62 /* --------------------------------------------------------------------- 67 63 * Registers
+1 -2
drivers/hwmon/f75375s.c
··· 39 39 /* Addresses to scan */ 40 40 static const unsigned short normal_i2c[] = { 0x2d, 0x2e, I2C_CLIENT_END }; 41 41 42 - /* Insmod parameters */ 43 - I2C_CLIENT_INSMOD_2(f75373, f75375); 42 + enum chips { f75373, f75375 }; 44 43 45 44 /* Fintek F75375 registers */ 46 45 #define F75375_REG_CONFIG0 0x0
+2 -1
drivers/hwmon/fschmd.c
··· 56 56 module_param(nowayout, int, 0); 57 57 MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=" 58 58 __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); 59 - I2C_CLIENT_INSMOD_7(fscpos, fscher, fscscy, fschrc, fschmd, fschds, fscsyl); 59 + 60 + enum chips { fscpos, fscher, fscscy, fschrc, fschmd, fschds, fscsyl }; 60 61 61 62 /* 62 63 * The FSCHMD registers and other defines
+1 -2
drivers/hwmon/gl518sm.c
··· 46 46 /* Addresses to scan */ 47 47 static const unsigned short normal_i2c[] = { 0x2c, 0x2d, I2C_CLIENT_END }; 48 48 49 - /* Insmod parameters */ 50 - I2C_CLIENT_INSMOD_2(gl518sm_r00, gl518sm_r80); 49 + enum chips { gl518sm_r00, gl518sm_r80 }; 51 50 52 51 /* Many GL518 constants specified below */ 53 52
+1 -2
drivers/hwmon/lm78.c
··· 41 41 0x2e, 0x2f, I2C_CLIENT_END }; 42 42 static unsigned short isa_address = 0x290; 43 43 44 - /* Insmod parameters */ 45 - I2C_CLIENT_INSMOD_2(lm78, lm79); 44 + enum chips { lm78, lm79 }; 46 45 47 46 /* Many LM78 constants specified below */ 48 47
+1 -5
drivers/hwmon/lm83.c
··· 51 51 static const unsigned short normal_i2c[] = { 52 52 0x18, 0x19, 0x1a, 0x29, 0x2a, 0x2b, 0x4c, 0x4d, 0x4e, I2C_CLIENT_END }; 53 53 54 - /* 55 - * Insmod parameters 56 - */ 57 - 58 - I2C_CLIENT_INSMOD_2(lm83, lm82); 54 + enum chips { lm83, lm82 }; 59 55 60 56 /* 61 57 * The LM83 registers
+5 -3
drivers/hwmon/lm85.c
··· 38 38 /* Addresses to scan */ 39 39 static const unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END }; 40 40 41 - /* Insmod parameters */ 42 - I2C_CLIENT_INSMOD_7(lm85b, lm85c, adm1027, adt7463, adt7468, emc6d100, 43 - emc6d102); 41 + enum chips { 42 + any_chip, lm85b, lm85c, 43 + adm1027, adt7463, adt7468, 44 + emc6d100, emc6d102 45 + }; 44 46 45 47 /* The LM85 registers */ 46 48
+1 -5
drivers/hwmon/lm87.c
··· 74 74 75 75 static const unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END }; 76 76 77 - /* 78 - * Insmod parameters 79 - */ 80 - 81 - I2C_CLIENT_INSMOD_2(lm87, adm1024); 77 + enum chips { lm87, adm1024 }; 82 78 83 79 /* 84 80 * The LM87 registers
+1 -6
drivers/hwmon/lm90.c
··· 93 93 static const unsigned short normal_i2c[] = { 94 94 0x18, 0x19, 0x1a, 0x29, 0x2a, 0x2b, 0x4c, 0x4d, 0x4e, I2C_CLIENT_END }; 95 95 96 - /* 97 - * Insmod parameters 98 - */ 99 - 100 - I2C_CLIENT_INSMOD_8(lm90, adm1032, lm99, lm86, max6657, adt7461, max6680, 101 - max6646); 96 + enum chips { lm90, adm1032, lm99, lm86, max6657, adt7461, max6680, max6646 }; 102 97 103 98 /* 104 99 * The LM90 registers
+1 -1
drivers/hwmon/thmc50.c
··· 35 35 static const unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END }; 36 36 37 37 /* Insmod parameters */ 38 - I2C_CLIENT_INSMOD_2(thmc50, adm1022); 38 + enum chips { thmc50, adm1022 }; 39 39 40 40 static unsigned short adm1022_temp3[16]; 41 41 static unsigned int adm1022_temp3_num;
+1 -2
drivers/hwmon/tmp401.c
··· 42 42 /* Addresses to scan */ 43 43 static const unsigned short normal_i2c[] = { 0x4c, I2C_CLIENT_END }; 44 44 45 - /* Insmod parameters */ 46 - I2C_CLIENT_INSMOD_2(tmp401, tmp411); 45 + enum chips { tmp401, tmp411 }; 47 46 48 47 /* 49 48 * The TMP401 registers, note some registers have different addresses for
+1 -2
drivers/hwmon/tmp421.c
··· 39 39 static unsigned short normal_i2c[] = { 0x2a, 0x4c, 0x4d, 0x4e, 0x4f, 40 40 I2C_CLIENT_END }; 41 41 42 - /* Insmod parameters */ 43 - I2C_CLIENT_INSMOD_3(tmp421, tmp422, tmp423); 42 + enum chips { tmp421, tmp422, tmp423 }; 44 43 45 44 /* The TMP421 registers */ 46 45 #define TMP421_CONFIG_REG_1 0x09
+3 -2
drivers/hwmon/w83781d.c
··· 56 56 /* Addresses to scan */ 57 57 static const unsigned short normal_i2c[] = { 0x28, 0x29, 0x2a, 0x2b, 0x2c, 0x2d, 58 58 0x2e, 0x2f, I2C_CLIENT_END }; 59 - /* Insmod parameters */ 60 - I2C_CLIENT_INSMOD_4(w83781d, w83782d, w83783s, as99127f); 61 59 60 + enum chips { w83781d, w83782d, w83783s, as99127f }; 61 + 62 + /* Insmod parameters */ 62 63 static unsigned short force_subclients[4]; 63 64 module_param_array(force_subclients, short, NULL, 0); 64 65 MODULE_PARM_DESC(force_subclients, "List of subclient addresses: "
-24
include/linux/i2c.h
··· 602 602 module_param_array(var, short, &var##_num, 0); \ 603 603 MODULE_PARM_DESC(var, desc) 604 604 605 - /* These are the ones you want to use in your own drivers. Pick the one 606 - which matches the number of devices the driver differenciates between. */ 607 - #define I2C_CLIENT_INSMOD_2(chip1, chip2) \ 608 - enum chips { any_chip, chip1, chip2 } 609 - 610 - #define I2C_CLIENT_INSMOD_3(chip1, chip2, chip3) \ 611 - enum chips { any_chip, chip1, chip2, chip3 } 612 - 613 - #define I2C_CLIENT_INSMOD_4(chip1, chip2, chip3, chip4) \ 614 - enum chips { any_chip, chip1, chip2, chip3, chip4 } 615 - 616 - #define I2C_CLIENT_INSMOD_5(chip1, chip2, chip3, chip4, chip5) \ 617 - enum chips { any_chip, chip1, chip2, chip3, chip4, chip5 } 618 - 619 - #define I2C_CLIENT_INSMOD_6(chip1, chip2, chip3, chip4, chip5, chip6) \ 620 - enum chips { any_chip, chip1, chip2, chip3, chip4, chip5, chip6 } 621 - 622 - #define I2C_CLIENT_INSMOD_7(chip1, chip2, chip3, chip4, chip5, chip6, chip7) \ 623 - enum chips { any_chip, chip1, chip2, chip3, chip4, chip5, chip6, \ 624 - chip7 } 625 - 626 - #define I2C_CLIENT_INSMOD_8(chip1, chip2, chip3, chip4, chip5, chip6, chip7, chip8) \ 627 - enum chips { any_chip, chip1, chip2, chip3, chip4, chip5, chip6, \ 628 - chip7, chip8 } 629 605 #endif /* __KERNEL__ */ 630 606 #endif /* _LINUX_I2C_H */