Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

vdpa/mlx5: Clear and reinitialize software VQ data on reset

The hardware VQ configuration is mirrored by data in struct
mlx5_vdpa_virtqueue . Instead of clearing just a few fields at reset,
fully clear the struct and initialize with the appropriate default
values.

As clear_vqs_ready() is used only during reset, get rid of it.

Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
Acked-by: Eugenio Pérez <eperezma@redhat.com>
Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Message-Id: <20240626-stage-vdpa-vq-precreate-v2-8-560c491078df@nvidia.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

authored by

Dragos Tatulea and committed by
Michael S. Tsirkin
e5bcbd1d 1835ed4a

+3 -13
+3 -13
drivers/vdpa/mlx5/net/mlx5_vnet.c
··· 2941 2941 ndev->setup = false; 2942 2942 } 2943 2943 2944 - static void clear_vqs_ready(struct mlx5_vdpa_net *ndev) 2945 - { 2946 - int i; 2947 - 2948 - for (i = 0; i < ndev->mvdev.max_vqs; i++) { 2949 - ndev->vqs[i].ready = false; 2950 - ndev->vqs[i].modified_fields = 0; 2951 - } 2952 - 2953 - ndev->mvdev.cvq.ready = false; 2954 - } 2955 - 2956 2944 static int setup_cvq_vring(struct mlx5_vdpa_dev *mvdev) 2957 2945 { 2958 2946 struct mlx5_control_vq *cvq = &mvdev->cvq; ··· 3023 3035 down_write(&ndev->reslock); 3024 3036 unregister_link_notifier(ndev); 3025 3037 teardown_vq_resources(ndev); 3026 - clear_vqs_ready(ndev); 3038 + init_mvqs(ndev); 3039 + 3027 3040 if (flags & VDPA_RESET_F_CLEAN_MAP) 3028 3041 mlx5_vdpa_destroy_mr_resources(&ndev->mvdev); 3029 3042 ndev->mvdev.status = 0; 3030 3043 ndev->mvdev.suspended = false; 3031 3044 ndev->cur_num_vqs = MLX5V_DEFAULT_VQ_COUNT; 3045 + ndev->mvdev.cvq.ready = false; 3032 3046 ndev->mvdev.cvq.received_desc = 0; 3033 3047 ndev->mvdev.cvq.completed_desc = 0; 3034 3048 memset(ndev->event_cbs, 0, sizeof(*ndev->event_cbs) * (mvdev->max_vqs + 1));