Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mm: pass VM_BUG_ON() reason to dump_page()

I recently added a patch to let folks pass a "reason" string dump_page()
which gets dumped out along with the page's data. This essentially
saves the bug-reader a trip in to the source to figure out why we
BUG_ON()'d.

The new VM_BUG_ON_PAGE() passes in NULL for "reason". It seems like we
might as well pass the BUG_ON() condition if we have it. This will
bloat kernels a bit with ~160 new strings, but this is all under a
debugging option anyway.

page:ffffea0008560280 count:1 mapcount:0 mapping:(null) index:0x0
page flags: 0xbfffc0000000001(locked)
page dumped because: VM_BUG_ON_PAGE(PageLocked(page))
------------[ cut here ]------------
kernel BUG at /home/davehans/linux.git/mm/filemap.c:464!
invalid opcode: 0000 [#1] SMP
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.14.0+ #251
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
...

[akpm@linux-foundation.org: include stringify.h]
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Davidlohr Bueso <davidlohr@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Dave Hansen and committed by
Linus Torvalds
e4f67422 3dae7fec

+9 -2
+9 -2
include/linux/mmdebug.h
··· 1 1 #ifndef LINUX_MM_DEBUG_H 2 2 #define LINUX_MM_DEBUG_H 1 3 3 4 + #include <linux/stringify.h> 5 + 4 6 struct page; 5 7 6 8 extern void dump_page(struct page *page, const char *reason); ··· 11 9 12 10 #ifdef CONFIG_DEBUG_VM 13 11 #define VM_BUG_ON(cond) BUG_ON(cond) 14 - #define VM_BUG_ON_PAGE(cond, page) \ 15 - do { if (unlikely(cond)) { dump_page(page, NULL); BUG(); } } while (0) 12 + #define VM_BUG_ON_PAGE(cond, page) \ 13 + do { \ 14 + if (unlikely(cond)) { \ 15 + dump_page(page, "VM_BUG_ON_PAGE(" __stringify(cond)")");\ 16 + BUG(); \ 17 + } \ 18 + } while (0) 16 19 #define VM_WARN_ON(cond) WARN_ON(cond) 17 20 #define VM_WARN_ON_ONCE(cond) WARN_ON_ONCE(cond) 18 21 #else