Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scsi: target/iblock: Fix protection error with blocks greater than 512B

The sector size of the block layer is 512 bytes, but integrity interval
size might be different (in case of 4K block size of the media). At the
initiator side the virtual start sector is the one that was originally
submitted by the block layer (512 bytes) for the Reftag usage. The
initiator converts the Reftag to integrity interval units and sends it to
the target. So the target virtual start sector should be calculated at
integrity interval units. prepare_fn() and complete_fn() don't remap
correctly the Reftag when using incorrect units of the virtual start
sector, which leads to the following protection error at the device:

"blk_update_request: protection error, dev sdb, sector 2048 op 0x0:(READ)
flags 0x10000 phys_seg 1 prio class 0"

To fix that, set the seed in integrity interval units.

Link: https://lore.kernel.org/r/1576078562-15240-1-git-send-email-israelr@mellanox.com
Signed-off-by: Israel Rukshin <israelr@mellanox.com>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Israel Rukshin and committed by
Martin K. Petersen
e4dc9a4c 71482fde

+3 -1
+3 -1
drivers/target/target_core_iblock.c
··· 646 646 } 647 647 648 648 bip->bip_iter.bi_size = bio_integrity_bytes(bi, bio_sectors(bio)); 649 - bip_set_seed(bip, bio->bi_iter.bi_sector); 649 + /* virtual start sector must be in integrity interval units */ 650 + bip_set_seed(bip, bio->bi_iter.bi_sector >> 651 + (bi->interval_exp - SECTOR_SHIFT)); 650 652 651 653 pr_debug("IBLOCK BIP Size: %u Sector: %llu\n", bip->bip_iter.bi_size, 652 654 (unsigned long long)bip->bip_iter.bi_sector);