Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Merge tag 'perf-urgent-for-mingo-20160726' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent

Pull perf/urgent fixes from Arnaldo Carvalho de Melo:

- Fix obtaining the 'start' address for a kernel module on s390, where
.text doesn't coincide with the start of the module as reported in
/proc/modules (Song Shan Gong)

- Use official ELF e_machine value for BPF objects generated via perf + LLVM
when specifying BPF scriptlet in 'perf record/trace --event' (Wang Nan)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>

+36 -1
+6 -1
tools/lib/bpf/libbpf.c
··· 37 37 #include "libbpf.h" 38 38 #include "bpf.h" 39 39 40 + #ifndef EM_BPF 41 + #define EM_BPF 247 42 + #endif 43 + 40 44 #define __printf(a, b) __attribute__((format(printf, a, b))) 41 45 42 46 __printf(1, 2) ··· 443 439 } 444 440 ep = &obj->efile.ehdr; 445 441 446 - if ((ep->e_type != ET_REL) || (ep->e_machine != 0)) { 442 + /* Old LLVM set e_machine to EM_NONE */ 443 + if ((ep->e_type != ET_REL) || (ep->e_machine && (ep->e_machine != EM_BPF))) { 447 444 pr_warning("%s is not an eBPF object file\n", 448 445 obj->path); 449 446 err = -LIBBPF_ERRNO__FORMAT;
+2
tools/perf/arch/s390/util/Build
··· 2 2 libperf-y += kvm-stat.o 3 3 4 4 libperf-$(CONFIG_DWARF) += dwarf-regs.o 5 + 6 + libperf-y += machine.o
+19
tools/perf/arch/s390/util/machine.c
··· 1 + #include <unistd.h> 2 + #include <stdio.h> 3 + #include <string.h> 4 + #include "util.h" 5 + #include "machine.h" 6 + #include "api/fs/fs.h" 7 + 8 + int arch__fix_module_text_start(u64 *start, const char *name) 9 + { 10 + char path[PATH_MAX]; 11 + 12 + snprintf(path, PATH_MAX, "module/%.*s/sections/.text", 13 + (int)strlen(name) - 2, name + 1); 14 + 15 + if (sysfs__read_ull(path, (unsigned long long *)start) < 0) 16 + return -1; 17 + 18 + return 0; 19 + }
+8
tools/perf/util/machine.c
··· 1093 1093 1094 1094 return map_groups__set_modules_path_dir(&machine->kmaps, modules_path, 0); 1095 1095 } 1096 + int __weak arch__fix_module_text_start(u64 *start __maybe_unused, 1097 + const char *name __maybe_unused) 1098 + { 1099 + return 0; 1100 + } 1096 1101 1097 1102 static int machine__create_module(void *arg, const char *name, u64 start) 1098 1103 { 1099 1104 struct machine *machine = arg; 1100 1105 struct map *map; 1106 + 1107 + if (arch__fix_module_text_start(&start, name) < 0) 1108 + return -1; 1101 1109 1102 1110 map = machine__findnew_module_map(machine, start, name); 1103 1111 if (map == NULL)
+1
tools/perf/util/machine.h
··· 216 216 217 217 struct map *machine__findnew_module_map(struct machine *machine, u64 start, 218 218 const char *filename); 219 + int arch__fix_module_text_start(u64 *start, const char *name); 219 220 220 221 int __machine__load_kallsyms(struct machine *machine, const char *filename, 221 222 enum map_type type, bool no_kcore, symbol_filter_t filter);