Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] tda18212: rename state from 'priv' to 'dev'

foo_dev seems to be most correct term for the structure holding data
of each device instance. It is most used term in Kernel codebase and also
examples from book Linux Device Drivers, Third Edition, uses it.

Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

authored by

Antti Palosaari and committed by
Mauro Carvalho Chehab
e4a42e18 bdb32655

+51 -53
+51 -53
drivers/media/tuners/tda18212.c
··· 23 23 /* Max transfer size done by I2C transfer functions */ 24 24 #define MAX_XFER_SIZE 64 25 25 26 - struct tda18212_priv { 26 + struct tda18212_dev { 27 27 struct tda18212_config cfg; 28 28 struct i2c_client *client; 29 29 ··· 31 31 }; 32 32 33 33 /* write multiple registers */ 34 - static int tda18212_wr_regs(struct tda18212_priv *priv, u8 reg, u8 *val, 35 - int len) 34 + static int tda18212_wr_regs(struct tda18212_dev *dev, u8 reg, u8 *val, int len) 36 35 { 37 36 int ret; 38 37 u8 buf[MAX_XFER_SIZE]; 39 38 struct i2c_msg msg[1] = { 40 39 { 41 - .addr = priv->client->addr, 40 + .addr = dev->client->addr, 42 41 .flags = 0, 43 42 .len = 1 + len, 44 43 .buf = buf, ··· 45 46 }; 46 47 47 48 if (1 + len > sizeof(buf)) { 48 - dev_warn(&priv->client->dev, 49 + dev_warn(&dev->client->dev, 49 50 "i2c wr reg=%04x: len=%d is too big!\n", 50 51 reg, len); 51 52 return -EINVAL; ··· 54 55 buf[0] = reg; 55 56 memcpy(&buf[1], val, len); 56 57 57 - ret = i2c_transfer(priv->client->adapter, msg, 1); 58 + ret = i2c_transfer(dev->client->adapter, msg, 1); 58 59 if (ret == 1) { 59 60 ret = 0; 60 61 } else { 61 - dev_warn(&priv->client->dev, 62 + dev_warn(&dev->client->dev, 62 63 "i2c wr failed=%d reg=%02x len=%d\n", 63 64 ret, reg, len); 64 65 ret = -EREMOTEIO; ··· 67 68 } 68 69 69 70 /* read multiple registers */ 70 - static int tda18212_rd_regs(struct tda18212_priv *priv, u8 reg, u8 *val, 71 - int len) 71 + static int tda18212_rd_regs(struct tda18212_dev *dev, u8 reg, u8 *val, int len) 72 72 { 73 73 int ret; 74 74 u8 buf[MAX_XFER_SIZE]; 75 75 struct i2c_msg msg[2] = { 76 76 { 77 - .addr = priv->client->addr, 77 + .addr = dev->client->addr, 78 78 .flags = 0, 79 79 .len = 1, 80 80 .buf = &reg, 81 81 }, { 82 - .addr = priv->client->addr, 82 + .addr = dev->client->addr, 83 83 .flags = I2C_M_RD, 84 84 .len = len, 85 85 .buf = buf, ··· 86 88 }; 87 89 88 90 if (len > sizeof(buf)) { 89 - dev_warn(&priv->client->dev, 91 + dev_warn(&dev->client->dev, 90 92 "i2c rd reg=%04x: len=%d is too big!\n", 91 93 reg, len); 92 94 return -EINVAL; 93 95 } 94 96 95 - ret = i2c_transfer(priv->client->adapter, msg, 2); 97 + ret = i2c_transfer(dev->client->adapter, msg, 2); 96 98 if (ret == 2) { 97 99 memcpy(val, buf, len); 98 100 ret = 0; 99 101 } else { 100 - dev_warn(&priv->client->dev, 102 + dev_warn(&dev->client->dev, 101 103 "i2c rd failed=%d reg=%02x len=%d\n", 102 104 ret, reg, len); 103 105 ret = -EREMOTEIO; ··· 107 109 } 108 110 109 111 /* write single register */ 110 - static int tda18212_wr_reg(struct tda18212_priv *priv, u8 reg, u8 val) 112 + static int tda18212_wr_reg(struct tda18212_dev *dev, u8 reg, u8 val) 111 113 { 112 - return tda18212_wr_regs(priv, reg, &val, 1); 114 + return tda18212_wr_regs(dev, reg, &val, 1); 113 115 } 114 116 115 117 /* read single register */ 116 - static int tda18212_rd_reg(struct tda18212_priv *priv, u8 reg, u8 *val) 118 + static int tda18212_rd_reg(struct tda18212_dev *dev, u8 reg, u8 *val) 117 119 { 118 - return tda18212_rd_regs(priv, reg, val, 1); 120 + return tda18212_rd_regs(dev, reg, val, 1); 119 121 } 120 122 121 123 #if 0 /* keep, useful when developing driver */ 122 - static void tda18212_dump_regs(struct tda18212_priv *priv) 124 + static void tda18212_dump_regs(struct tda18212_dev *dev) 123 125 { 124 126 int i; 125 127 u8 buf[256]; 126 128 127 129 #define TDA18212_RD_LEN 32 128 130 for (i = 0; i < sizeof(buf); i += TDA18212_RD_LEN) 129 - tda18212_rd_regs(priv, i, &buf[i], TDA18212_RD_LEN); 131 + tda18212_rd_regs(dev, i, &buf[i], TDA18212_RD_LEN); 130 132 131 133 print_hex_dump(KERN_INFO, "", DUMP_PREFIX_OFFSET, 32, 1, buf, 132 134 sizeof(buf), true); ··· 137 139 138 140 static int tda18212_set_params(struct dvb_frontend *fe) 139 141 { 140 - struct tda18212_priv *priv = fe->tuner_priv; 142 + struct tda18212_dev *dev = fe->tuner_priv; 141 143 struct dtv_frontend_properties *c = &fe->dtv_property_cache; 142 144 int ret, i; 143 145 u32 if_khz; ··· 166 168 [ATSC_QAM] = { 0x7d, 0x20, 0x63 }, 167 169 }; 168 170 169 - dev_dbg(&priv->client->dev, 171 + dev_dbg(&dev->client->dev, 170 172 "delivery_system=%d frequency=%d bandwidth_hz=%d\n", 171 173 c->delivery_system, c->frequency, 172 174 c->bandwidth_hz); ··· 176 178 177 179 switch (c->delivery_system) { 178 180 case SYS_ATSC: 179 - if_khz = priv->cfg.if_atsc_vsb; 181 + if_khz = dev->cfg.if_atsc_vsb; 180 182 i = ATSC_VSB; 181 183 break; 182 184 case SYS_DVBC_ANNEX_B: 183 - if_khz = priv->cfg.if_atsc_qam; 185 + if_khz = dev->cfg.if_atsc_qam; 184 186 i = ATSC_QAM; 185 187 break; 186 188 case SYS_DVBT: 187 189 switch (c->bandwidth_hz) { 188 190 case 6000000: 189 - if_khz = priv->cfg.if_dvbt_6; 191 + if_khz = dev->cfg.if_dvbt_6; 190 192 i = DVBT_6; 191 193 break; 192 194 case 7000000: 193 - if_khz = priv->cfg.if_dvbt_7; 195 + if_khz = dev->cfg.if_dvbt_7; 194 196 i = DVBT_7; 195 197 break; 196 198 case 8000000: 197 - if_khz = priv->cfg.if_dvbt_8; 199 + if_khz = dev->cfg.if_dvbt_8; 198 200 i = DVBT_8; 199 201 break; 200 202 default: ··· 205 207 case SYS_DVBT2: 206 208 switch (c->bandwidth_hz) { 207 209 case 6000000: 208 - if_khz = priv->cfg.if_dvbt2_6; 210 + if_khz = dev->cfg.if_dvbt2_6; 209 211 i = DVBT2_6; 210 212 break; 211 213 case 7000000: 212 - if_khz = priv->cfg.if_dvbt2_7; 214 + if_khz = dev->cfg.if_dvbt2_7; 213 215 i = DVBT2_7; 214 216 break; 215 217 case 8000000: 216 - if_khz = priv->cfg.if_dvbt2_8; 218 + if_khz = dev->cfg.if_dvbt2_8; 217 219 i = DVBT2_8; 218 220 break; 219 221 default: ··· 223 225 break; 224 226 case SYS_DVBC_ANNEX_A: 225 227 case SYS_DVBC_ANNEX_C: 226 - if_khz = priv->cfg.if_dvbc; 228 + if_khz = dev->cfg.if_dvbc; 227 229 i = DVBC_8; 228 230 break; 229 231 default: ··· 231 233 goto error; 232 234 } 233 235 234 - ret = tda18212_wr_reg(priv, 0x23, bw_params[i][2]); 236 + ret = tda18212_wr_reg(dev, 0x23, bw_params[i][2]); 235 237 if (ret) 236 238 goto error; 237 239 238 - ret = tda18212_wr_reg(priv, 0x06, 0x00); 240 + ret = tda18212_wr_reg(dev, 0x06, 0x00); 239 241 if (ret) 240 242 goto error; 241 243 242 - ret = tda18212_wr_reg(priv, 0x0f, bw_params[i][0]); 244 + ret = tda18212_wr_reg(dev, 0x0f, bw_params[i][0]); 243 245 if (ret) 244 246 goto error; 245 247 ··· 252 254 buf[6] = ((c->frequency / 1000) >> 0) & 0xff; 253 255 buf[7] = 0xc1; 254 256 buf[8] = 0x01; 255 - ret = tda18212_wr_regs(priv, 0x12, buf, sizeof(buf)); 257 + ret = tda18212_wr_regs(dev, 0x12, buf, sizeof(buf)); 256 258 if (ret) 257 259 goto error; 258 260 259 261 /* actual IF rounded as it is on register */ 260 - priv->if_frequency = buf[3] * 50 * 1000; 262 + dev->if_frequency = buf[3] * 50 * 1000; 261 263 262 264 exit: 263 265 if (fe->ops.i2c_gate_ctrl) ··· 266 268 return ret; 267 269 268 270 error: 269 - dev_dbg(&priv->client->dev, "failed=%d\n", ret); 271 + dev_dbg(&dev->client->dev, "failed=%d\n", ret); 270 272 goto exit; 271 273 } 272 274 273 275 static int tda18212_get_if_frequency(struct dvb_frontend *fe, u32 *frequency) 274 276 { 275 - struct tda18212_priv *priv = fe->tuner_priv; 277 + struct tda18212_dev *dev = fe->tuner_priv; 276 278 277 - *frequency = priv->if_frequency; 279 + *frequency = dev->if_frequency; 278 280 279 281 return 0; 280 282 } ··· 297 299 { 298 300 struct tda18212_config *cfg = client->dev.platform_data; 299 301 struct dvb_frontend *fe = cfg->fe; 300 - struct tda18212_priv *priv; 302 + struct tda18212_dev *dev; 301 303 int ret; 302 304 u8 chip_id = chip_id; 303 305 char *version; 304 306 305 - priv = kzalloc(sizeof(*priv), GFP_KERNEL); 306 - if (!priv) { 307 + dev = kzalloc(sizeof(*dev), GFP_KERNEL); 308 + if (dev == NULL) { 307 309 ret = -ENOMEM; 308 310 dev_err(&client->dev, "kzalloc() failed\n"); 309 311 goto err; 310 312 } 311 313 312 - memcpy(&priv->cfg, cfg, sizeof(struct tda18212_config)); 313 - priv->client = client; 314 + memcpy(&dev->cfg, cfg, sizeof(struct tda18212_config)); 315 + dev->client = client; 314 316 315 317 /* check if the tuner is there */ 316 318 if (fe->ops.i2c_gate_ctrl) 317 319 fe->ops.i2c_gate_ctrl(fe, 1); /* open I2C-gate */ 318 320 319 - ret = tda18212_rd_reg(priv, 0x00, &chip_id); 320 - dev_dbg(&priv->client->dev, "chip_id=%02x\n", chip_id); 321 + ret = tda18212_rd_reg(dev, 0x00, &chip_id); 322 + dev_dbg(&dev->client->dev, "chip_id=%02x\n", chip_id); 321 323 322 324 if (fe->ops.i2c_gate_ctrl) 323 325 fe->ops.i2c_gate_ctrl(fe, 0); /* close I2C-gate */ ··· 337 339 goto err; 338 340 } 339 341 340 - dev_info(&priv->client->dev, 342 + dev_info(&dev->client->dev, 341 343 "NXP TDA18212HN/%s successfully identified\n", version); 342 344 343 - fe->tuner_priv = priv; 345 + fe->tuner_priv = dev; 344 346 memcpy(&fe->ops.tuner_ops, &tda18212_tuner_ops, 345 347 sizeof(struct dvb_tuner_ops)); 346 - i2c_set_clientdata(client, priv); 348 + i2c_set_clientdata(client, dev); 347 349 348 350 return 0; 349 351 err: 350 352 dev_dbg(&client->dev, "failed=%d\n", ret); 351 - kfree(priv); 353 + kfree(dev); 352 354 return ret; 353 355 } 354 356 355 357 static int tda18212_remove(struct i2c_client *client) 356 358 { 357 - struct tda18212_priv *priv = i2c_get_clientdata(client); 358 - struct dvb_frontend *fe = priv->cfg.fe; 359 + struct tda18212_dev *dev = i2c_get_clientdata(client); 360 + struct dvb_frontend *fe = dev->cfg.fe; 359 361 360 362 dev_dbg(&client->dev, "\n"); 361 363 362 364 memset(&fe->ops.tuner_ops, 0, sizeof(struct dvb_tuner_ops)); 363 365 fe->tuner_priv = NULL; 364 - kfree(priv); 366 + kfree(dev); 365 367 366 368 return 0; 367 369 }