Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

platform/surface: SURFACE_PLATFORMS should depend on ACPI

All Microsoft Surface platform-specific device drivers depend on ACPI,
but the gatekeeper symbol SURFACE_PLATFORMS does not. Hence when the
user is configuring a kernel without ACPI support, he is still asked
about Microsoft Surface drivers, even though this question is
irrelevant.

Fix this by moving the dependency on ACPI from the individual driver
symbols to SURFACE_PLATFORMS.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20201216133752.1321978-1-geert@linux-m68k.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

authored by

Geert Uytterhoeven and committed by
Hans de Goede
e4a02c7a 6a4b1f2d

+4 -4
+4 -4
drivers/platform/surface/Kconfig
··· 5 5 6 6 menuconfig SURFACE_PLATFORMS 7 7 bool "Microsoft Surface Platform-Specific Device Drivers" 8 + depends on ACPI 8 9 default y 9 10 help 10 11 Say Y here to get to see options for platform-specific device drivers ··· 30 29 31 30 config SURFACE_3_BUTTON 32 31 tristate "Power/home/volume buttons driver for Microsoft Surface 3 tablet" 33 - depends on ACPI && KEYBOARD_GPIO && I2C 32 + depends on KEYBOARD_GPIO && I2C 34 33 help 35 34 This driver handles the power/home/volume buttons on the Microsoft Surface 3 tablet. 36 35 37 36 config SURFACE_3_POWER_OPREGION 38 37 tristate "Surface 3 battery platform operation region support" 39 - depends on ACPI && I2C 38 + depends on I2C 40 39 help 41 40 This driver provides support for ACPI operation 42 41 region of the Surface 3 battery platform driver. 43 42 44 43 config SURFACE_GPE 45 44 tristate "Surface GPE/Lid Support Driver" 46 - depends on ACPI 47 45 depends on DMI 48 46 help 49 47 This driver marks the GPEs related to the ACPI lid device found on ··· 52 52 53 53 config SURFACE_PRO3_BUTTON 54 54 tristate "Power/home/volume buttons driver for Microsoft Surface Pro 3/4 tablet" 55 - depends on ACPI && INPUT 55 + depends on INPUT 56 56 help 57 57 This driver handles the power/home/volume buttons on the Microsoft Surface Pro 3/4 tablet. 58 58