Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: i2c: mt9t112: Use the v4l2 helper for obtaining the clock

devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

authored by

Mehdi Djait and committed by
Hans Verkuil
e49ee5d8 d1360982

+5 -6
+5 -6
drivers/media/i2c/mt9t112.c
··· 1078 1078 1079 1079 v4l2_i2c_subdev_init(&priv->subdev, client, &mt9t112_subdev_ops); 1080 1080 1081 - priv->clk = devm_clk_get(&client->dev, "extclk"); 1082 - if (PTR_ERR(priv->clk) == -ENOENT) { 1081 + priv->clk = devm_v4l2_sensor_clk_get(&client->dev, "extclk"); 1082 + if (PTR_ERR(priv->clk) == -ENOENT) 1083 1083 priv->clk = NULL; 1084 - } else if (IS_ERR(priv->clk)) { 1085 - dev_err(&client->dev, "Unable to get clock \"extclk\"\n"); 1086 - return PTR_ERR(priv->clk); 1087 - } 1084 + else if (IS_ERR(priv->clk)) 1085 + return dev_err_probe(&client->dev, PTR_ERR(priv->clk), 1086 + "Unable to get clock \"extclk\"\n"); 1088 1087 1089 1088 priv->standby_gpio = devm_gpiod_get_optional(&client->dev, "standby", 1090 1089 GPIOD_OUT_HIGH);