Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: (lm78) Remove use of i2c_match_id()

The function i2c_match_id() is used to fetch the matching ID from
the i2c_device_id table. This is often used to then retrieve the
matching driver_data. This can be done in one step with the helper
i2c_get_match_data().

This helper has a couple other benefits:
* It doesn't need the i2c_device_id passed in so we do not need
to have that forward declared, allowing us to remove those or
move the i2c_device_id table down to its more natural spot
with the other module info.
* It also checks for device match data, which allows for OF and
ACPI based probing. That means we do not have to manually check
those first and can remove those checks.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20240403203633.914389-15-afd@ti.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Andrew Davis and committed by
Guenter Roeck
e49d1a1d 5178911d

+1 -3
+1 -3
drivers/hwmon/lm78.c
··· 627 627 return -ENODEV; 628 628 } 629 629 630 - static const struct i2c_device_id lm78_i2c_id[]; 631 - 632 630 static int lm78_i2c_probe(struct i2c_client *client) 633 631 { 634 632 struct device *dev = &client->dev; ··· 638 640 return -ENOMEM; 639 641 640 642 data->client = client; 641 - data->type = i2c_match_id(lm78_i2c_id, client)->driver_data; 643 + data->type = (uintptr_t)i2c_get_match_data(client); 642 644 643 645 /* Initialize the LM78 chip */ 644 646 lm78_init_device(data);