Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] atmel-isi: update device tree bindings documentation

The original bindings documentation was incomplete (missing pinctrl-names,
missing endpoint node properties) and the example was out of date.

Add the missing information and tidy up the text.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

authored by

Hans Verkuil and committed by
Mauro Carvalho Chehab
e48f4eea a0c4164e

+51 -36
+51 -36
Documentation/devicetree/bindings/media/atmel-isi.txt
··· 1 - Atmel Image Sensor Interface (ISI) SoC Camera Subsystem 2 - ---------------------------------------------- 1 + Atmel Image Sensor Interface (ISI) 2 + ---------------------------------- 3 3 4 - Required properties: 5 - - compatible: must be "atmel,at91sam9g45-isi" 6 - - reg: physical base address and length of the registers set for the device; 7 - - interrupts: should contain IRQ line for the ISI; 8 - - clocks: list of clock specifiers, corresponding to entries in 9 - the clock-names property; 10 - - clock-names: must contain "isi_clk", which is the isi peripherial clock. 4 + Required properties for ISI: 5 + - compatible: must be "atmel,at91sam9g45-isi". 6 + - reg: physical base address and length of the registers set for the device. 7 + - interrupts: should contain IRQ line for the ISI. 8 + - clocks: list of clock specifiers, corresponding to entries in the clock-names 9 + property; please refer to clock-bindings.txt. 10 + - clock-names: required elements: "isi_clk". 11 + - pinctrl-names, pinctrl-0: please refer to pinctrl-bindings.txt. 11 12 12 - ISI supports a single port node with parallel bus. It should contain one 13 + ISI supports a single port node with parallel bus. It shall contain one 13 14 'port' child node with child 'endpoint' node. Please refer to the bindings 14 15 defined in Documentation/devicetree/bindings/media/video-interfaces.txt. 15 16 17 + Endpoint node properties 18 + ------------------------ 19 + 20 + - bus-width: <8> or <10> (mandatory) 21 + - hsync-active (default: active high) 22 + - vsync-active (default: active high) 23 + - pclk-sample (default: sample on falling edge) 24 + - remote-endpoint: A phandle to the bus receiver's endpoint node (mandatory). 25 + 16 26 Example: 17 - isi: isi@f0034000 { 18 - compatible = "atmel,at91sam9g45-isi"; 19 - reg = <0xf0034000 0x4000>; 20 - interrupts = <37 IRQ_TYPE_LEVEL_HIGH 5>; 21 27 22 - clocks = <&isi_clk>; 23 - clock-names = "isi_clk"; 28 + isi: isi@f0034000 { 29 + compatible = "atmel,at91sam9g45-isi"; 30 + reg = <0xf0034000 0x4000>; 31 + interrupts = <37 IRQ_TYPE_LEVEL_HIGH 5>; 32 + pinctrl-names = "default"; 33 + pinctrl-0 = <&pinctrl_isi_data_0_7>; 34 + clocks = <&isi_clk>; 35 + clock-names = "isi_clk"; 36 + port { 37 + isi_0: endpoint { 38 + remote-endpoint = <&ov2640_0>; 39 + bus-width = <8>; 40 + vsync-active = <1>; 41 + hsync-active = <1>; 42 + }; 43 + }; 44 + }; 24 45 46 + i2c1: i2c@f0018000 { 47 + ov2640: camera@30 { 48 + compatible = "ovti,ov2640"; 49 + reg = <0x30>; 25 50 pinctrl-names = "default"; 26 - pinctrl-0 = <&pinctrl_isi>; 51 + pinctrl-0 = <&pinctrl_pck0_as_isi_mck &pinctrl_sensor_power &pinctrl_sensor_reset>; 52 + resetb-gpios = <&pioE 11 GPIO_ACTIVE_LOW>; 53 + pwdn-gpios = <&pioE 13 GPIO_ACTIVE_HIGH>; 54 + clocks = <&pck0>; 55 + clock-names = "xvclk"; 56 + assigned-clocks = <&pck0>; 57 + assigned-clock-rates = <25000000>; 27 58 28 59 port { 29 - #address-cells = <1>; 30 - #size-cells = <0>; 31 - 32 - isi_0: endpoint { 33 - remote-endpoint = <&ov2640_0>; 60 + ov2640_0: endpoint { 61 + remote-endpoint = <&isi_0>; 34 62 bus-width = <8>; 35 63 }; 36 64 }; 37 65 }; 38 - 39 - i2c1: i2c@f0018000 { 40 - ov2640: camera@0x30 { 41 - compatible = "ovti,ov2640"; 42 - reg = <0x30>; 43 - 44 - port { 45 - ov2640_0: endpoint { 46 - remote-endpoint = <&isi_0>; 47 - bus-width = <8>; 48 - }; 49 - }; 50 - }; 51 - }; 66 + };