Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] drivers/media/dvb-frontends/stb6100.c: Removes useless kfree()

Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged exists@
position r.p1,r.p2;
expression e <= r.x,x,e1;
iterator I;
statement S;
@@
if (x@p1 == NULL) { ... when != I(x,...) S
when != e = e1
when != e += e1
when != e -= e1
when != ++e
when != --e
when != e++
when != e--
when != &e
kfree@p2(x); ... return ...; }
@ok depends on unchanged exists@
position any r.p1;
position r.p2;
expression x;
@@
... when != true x@p1 == NULL
kfree@p2(x);
@depends on !ok && unchanged@
position r.p2;
expression x;
@@
*kfree@p2(x);
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

authored by

Peter Senna Tschudin and committed by
Mauro Carvalho Chehab
e4533e65 4a0543ee

+2 -6
+2 -6
drivers/media/dvb-frontends/stb6100.c
··· 575 575 struct stb6100_state *state = NULL; 576 576 577 577 state = kzalloc(sizeof (struct stb6100_state), GFP_KERNEL); 578 - if (state == NULL) 579 - goto error; 578 + if (!state) 579 + return NULL; 580 580 581 581 state->config = config; 582 582 state->i2c = i2c; ··· 587 587 588 588 printk("%s: Attaching STB6100 \n", __func__); 589 589 return fe; 590 - 591 - error: 592 - kfree(state); 593 - return NULL; 594 590 } 595 591 596 592 static int stb6100_release(struct dvb_frontend *fe)