Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: mt6370: Annotate struct mt6370_priv with __counted_by

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct mt6370_priv.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230915201051.never.429-kees@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>

authored by

Kees Cook and committed by
Lee Jones
e3c9d952 476301c1

+2 -2
+1 -1
drivers/leds/flash/leds-mt6370-flash.c
··· 81 81 unsigned int fled_torch_used; 82 82 unsigned int leds_active; 83 83 unsigned int leds_count; 84 - struct mt6370_led leds[]; 84 + struct mt6370_led leds[] __counted_by(leds_count); 85 85 }; 86 86 87 87 static int mt6370_torch_brightness_set(struct led_classdev *lcdev, enum led_brightness level)
+1 -1
drivers/leds/rgb/leds-mt6370-rgb.c
··· 153 153 const struct mt6370_pdata *pdata; 154 154 unsigned int leds_count; 155 155 unsigned int leds_active; 156 - struct mt6370_led leds[]; 156 + struct mt6370_led leds[] __counted_by(leds_count); 157 157 }; 158 158 159 159 static const struct reg_field common_reg_fields[F_MAX_FIELDS] = {