Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

sched: Fix incorrect usage of for_each_cpu_mask() in select_fallback_rq()

The function for_each_cpu_mask() expects a *pointer* to struct
cpumask as its second argument, whereas select_fallback_rq()
passes the value itself.

And moreover, for_each_cpu_mask() has been marked as obselete
in include/linux/cpumask.h. So move to the more appropriate
for_each_cpu() variant.

Reported-by: Sasha Levin <levinsasha928@gmail.com>
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Dave Jones <davej@redhat.com>
Cc: Liu Chuansheng <chuansheng.liu@intel.com>
Cc: vapier@gentoo.org
Cc: rusty@rustcorp.com.au
Link: http://lkml.kernel.org/r/4F75BED4.9050005@linux.vnet.ibm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>

authored by

Srivatsa S. Bhat and committed by
Ingo Molnar
e3831edd 1f56ee7b

+2 -2
+2 -2
kernel/sched/core.c
··· 1268 1268 int dest_cpu; 1269 1269 1270 1270 /* Look for allowed, online CPU in same node. */ 1271 - for_each_cpu_mask(dest_cpu, *nodemask) { 1271 + for_each_cpu(dest_cpu, nodemask) { 1272 1272 if (!cpu_online(dest_cpu)) 1273 1273 continue; 1274 1274 if (!cpu_active(dest_cpu)) ··· 1279 1279 1280 1280 for (;;) { 1281 1281 /* Any allowed, online CPU? */ 1282 - for_each_cpu_mask(dest_cpu, *tsk_cpus_allowed(p)) { 1282 + for_each_cpu(dest_cpu, tsk_cpus_allowed(p)) { 1283 1283 if (!cpu_online(dest_cpu)) 1284 1284 continue; 1285 1285 if (!cpu_active(dest_cpu))