Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iio: trigger: stm32-timer: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230919174931.1417681-50-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Uwe Kleine-König and committed by
Jonathan Cameron
e377df03 548eb81d

+2 -4
+2 -4
drivers/iio/trigger/stm32-timer-trigger.c
··· 809 809 return 0; 810 810 } 811 811 812 - static int stm32_timer_trigger_remove(struct platform_device *pdev) 812 + static void stm32_timer_trigger_remove(struct platform_device *pdev) 813 813 { 814 814 struct stm32_timer_trigger *priv = platform_get_drvdata(pdev); 815 815 u32 val; ··· 824 824 825 825 if (priv->enabled) 826 826 clk_disable(priv->clk); 827 - 828 - return 0; 829 827 } 830 828 831 829 static int stm32_timer_trigger_suspend(struct device *dev) ··· 902 904 903 905 static struct platform_driver stm32_timer_trigger_driver = { 904 906 .probe = stm32_timer_trigger_probe, 905 - .remove = stm32_timer_trigger_remove, 907 + .remove_new = stm32_timer_trigger_remove, 906 908 .driver = { 907 909 .name = "stm32-timer-trigger", 908 910 .of_match_table = stm32_trig_of_match,