Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: libwx: fix memory leak in wx_setup_rx_resources

When wx_alloc_page_pool() failed in wx_setup_rx_resources(), it doesn't
release DMA buffer. Add dma_free_coherent() in the error path to release
the DMA buffer.

Fixes: 850b971110b2 ("net: libwx: Allocate Rx and Tx resources")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230418065450.2268522-1-shaozhengchao@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

authored by

Zhengchao Shao and committed by
Paolo Abeni
e315e7b8 a5962e0a

+4 -1
+4 -1
drivers/net/ethernet/wangxun/libwx/wx_lib.c
··· 1798 1798 ret = wx_alloc_page_pool(rx_ring); 1799 1799 if (ret < 0) { 1800 1800 dev_err(rx_ring->dev, "Page pool creation failed: %d\n", ret); 1801 - goto err; 1801 + goto err_desc; 1802 1802 } 1803 1803 1804 1804 return 0; 1805 + 1806 + err_desc: 1807 + dma_free_coherent(dev, rx_ring->size, rx_ring->desc, rx_ring->dma); 1805 1808 err: 1806 1809 kvfree(rx_ring->rx_buffer_info); 1807 1810 rx_ring->rx_buffer_info = NULL;