Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spi: bitbang: remove unneeded check

Remove an unneeded check. The SPI core (__spi_validate) takes care
that these fields are always populated.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Heiner Kallweit and committed by
Mark Brown
e30d8f23 c15f6ed3

+4 -14
+4 -14
drivers/spi/spi-bitbang.c
··· 272 272 struct spi_transfer *t = NULL; 273 273 unsigned cs_change; 274 274 int status; 275 - int do_setup = -1; 276 275 struct spi_device *spi = m->spi; 277 276 278 277 bitbang = spi_master_get_devdata(master); ··· 287 288 288 289 list_for_each_entry(t, &m->transfers, transfer_list) { 289 290 290 - /* override speed or wordsize? */ 291 - if (t->speed_hz || t->bits_per_word) 292 - do_setup = 1; 293 - 294 - /* init (-1) or override (1) transfer params */ 295 - if (do_setup != 0) { 296 - if (bitbang->setup_transfer) { 297 - status = bitbang->setup_transfer(spi, t); 298 - if (status < 0) 299 - break; 300 - } 301 - if (do_setup == -1) 302 - do_setup = 0; 291 + if (bitbang->setup_transfer) { 292 + status = bitbang->setup_transfer(spi, t); 293 + if (status < 0) 294 + break; 303 295 } 304 296 305 297 /* set up default clock polarity, and activate chip;