Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mfd: altera-sysmgr: Call of_node_put() only when of_parse_phandle() takes a ref

of_parse_phandle() returns a device_node with refcount incremented, which
the callee needs to call of_node_put() on when done. We should only call
of_node_put() when the property argument is provided though as otherwise
nothing has taken a reference on the node.

Fixes: f36e789a1f8d ("mfd: altera-sysmgr: Add SOCFPGA System Manager")
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20240220115012.471689-4-peter.griffin@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>

authored by

Peter Griffin and committed by
Lee Jones
e28c28a3 0db017f8

+3 -1
+3 -1
drivers/mfd/altera-sysmgr.c
··· 109 109 110 110 dev = driver_find_device_by_of_node(&altr_sysmgr_driver.driver, 111 111 (void *)sysmgr_np); 112 - of_node_put(sysmgr_np); 112 + if (property) 113 + of_node_put(sysmgr_np); 114 + 113 115 if (!dev) 114 116 return ERR_PTR(-EPROBE_DEFER); 115 117