Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

USB: OHCI: Use fallthrough pseudo-keyword

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20200707195351.GA4061@embeddedor
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Gustavo A. R. Silva and committed by
Greg Kroah-Hartman
e288fc98 0d9b6d49

+9 -9
+2 -2
drivers/usb/host/ohci-hcd.c
··· 385 385 ed_free (ohci, ed); 386 386 break; 387 387 } 388 - /* fall through */ 388 + fallthrough; 389 389 default: 390 390 /* caller was supposed to have unlinked any requests; 391 391 * that's not our job. can't recover; must leak ed. ··· 1051 1051 ed->ed_next = ohci->ed_rm_list; 1052 1052 ed->ed_prev = NULL; 1053 1053 ohci->ed_rm_list = ed; 1054 - /* FALLTHROUGH */ 1054 + fallthrough; 1055 1055 case ED_UNLINK: 1056 1056 break; 1057 1057 default:
+1 -1
drivers/usb/host/ohci-hub.c
··· 58 58 ohci->hc_control |= OHCI_USB_RESET; 59 59 ohci_writel (ohci, ohci->hc_control, &ohci->regs->control); 60 60 (void) ohci_readl (ohci, &ohci->regs->control); 61 - /* FALL THROUGH */ 61 + fallthrough; 62 62 case OHCI_USB_RESET: 63 63 status = -EBUSY; 64 64 ohci_dbg (ohci, "needs reinit!\n");
+3 -3
drivers/usb/host/ohci-q.c
··· 647 647 /* ... and periodic urbs have extra accounting */ 648 648 periodic = ohci_to_hcd(ohci)->self.bandwidth_int_reqs++ == 0 649 649 && ohci_to_hcd(ohci)->self.bandwidth_isoc_reqs == 0; 650 - /* FALLTHROUGH */ 650 + fallthrough; 651 651 case PIPE_BULK: 652 652 info = is_out 653 653 ? TD_T_TOGGLE | TD_CC | TD_DP_OUT ··· 879 879 case TD_DATAUNDERRUN: 880 880 if ((urb->transfer_flags & URB_SHORT_NOT_OK) == 0) 881 881 break; 882 - /* fallthrough */ 882 + fallthrough; 883 883 case TD_CC_STALL: 884 884 if (usb_pipecontrol (urb->pipe)) 885 885 break; 886 - /* fallthrough */ 886 + fallthrough; 887 887 default: 888 888 ohci_dbg (ohci, 889 889 "urb %p path %s ep%d%s %08x cc %d --> status %d\n",
+3 -3
drivers/usb/host/ohci-tmio.c
··· 97 97 switch (ohci->num_ports) { 98 98 default: 99 99 dev_err(&dev->dev, "Unsupported amount of ports: %d\n", ohci->num_ports); 100 - /* fall through */ 100 + fallthrough; 101 101 case 3: 102 102 pm |= CCR_PM_USBPW3; 103 - /* fall through */ 103 + fallthrough; 104 104 case 2: 105 105 pm |= CCR_PM_USBPW2; 106 - /* fall through */ 106 + fallthrough; 107 107 case 1: 108 108 pm |= CCR_PM_USBPW1; 109 109 }