Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

virtio_pmem: Check device status before requesting flush

If a pmem device is in a bad status, the driver side could wait for
host ack forever in virtio_pmem_flush(), causing the system to hang.

So add a status check in the beginning of virtio_pmem_flush() to return
early if the device is not activated.

Signed-off-by: Philip Chen <philipchen@chromium.org>
Message-Id: <20240826215313.2673566-1-philipchen@chromium.org>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com

authored by

Philip Chen and committed by
Michael S. Tsirkin
e25fbcd9 02e9e936

+9
+9
drivers/nvdimm/nd_virtio.c
··· 44 44 unsigned long flags; 45 45 int err, err1; 46 46 47 + /* 48 + * Don't bother to submit the request to the device if the device is 49 + * not activated. 50 + */ 51 + if (vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_NEEDS_RESET) { 52 + dev_info(&vdev->dev, "virtio pmem device needs a reset\n"); 53 + return -EIO; 54 + } 55 + 47 56 might_sleep(); 48 57 req_data = kmalloc(sizeof(*req_data), GFP_KERNEL); 49 58 if (!req_data)