Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: ctxfi - Work around emu20k1 glitch to prevent buffered sound data loss

Occasionally, on playback stream ringbuffer wraparound, the EMU20K1
hardware will momentarily return 0 instead of the proper current(loop)
address. This patch handles that case, fixing the problem of playback
position corruption and subsequent loss of buffered sound data, that
occurs with some common buffering layout patterns(e.g. multiple
simultaneous output streams with differently-sized or
non-power-of-2-sized buffers).

An alternate means of fixing the problem would be to read the ca
register continuously, until two sequential reads return the same
value; however, that would be a more invasive change, has performance
implications, and isn't necessary unless there are also issues with the
value not being updated atomically in regards to individual bits or
something similar(which I have not encountered through light testing).

I have no EMU20K2 hardware to confirm if the issue is present there,
but even if it's not, this change shouldn't break anything that's not
already broken.

Signed-off-by: Sarah Bessmer <aotos@fastmail.fm>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

authored by

Sarah Bessmer and committed by
Takashi Iwai
e240a469 2d82ea20

+5
+5
sound/pci/ctxfi/ctatc.c
··· 435 435 return 0; 436 436 position = src->ops->get_ca(src); 437 437 438 + if (position < apcm->vm_block->addr) { 439 + snd_printdd("ctxfi: bad ca - ca=0x%08x, vba=0x%08x, vbs=0x%08x\n", position, apcm->vm_block->addr, apcm->vm_block->size); 440 + position = apcm->vm_block->addr; 441 + } 442 + 438 443 size = apcm->vm_block->size; 439 444 max_cisz = src->multi * src->rsc.msr; 440 445 max_cisz = 128 * (max_cisz < 8 ? max_cisz : 8);