Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

s390/sclp_sdias: Add missing break and "fall through"

If the last block of the HSA is read, EVSTATE_ALL_STORED is returned
by SCLP. Because of a missing break in the switch statement two trace
entries are written in this case: "all stored" and "part stored".

This patch adds the missing break and also adds a "fall through"
comment to improve the readability.

Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Reported-by: David A Gilbert <DavidAGilbert@uk.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

authored by

Michael Holzheu and committed by
Martin Schwidefsky
e206d3da d0503513

+2
+2
drivers/s390/char/sclp_sdias.c
··· 242 242 switch (sdias_evbuf.event_status) { 243 243 case EVSTATE_ALL_STORED: 244 244 TRACE("all stored\n"); 245 + break; 245 246 case EVSTATE_PART_STORED: 246 247 TRACE("part stored: %i\n", sdias_evbuf.blk_cnt); 247 248 break; 248 249 case EVSTATE_NO_DATA: 249 250 TRACE("no data\n"); 251 + /* fall through */ 250 252 default: 251 253 pr_err("Error from SCLP while copying hsa. " 252 254 "Event status = %x\n",