Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

video: fbdev: arkfb: Error out if 'pixclock' equals zero

The userspace program could pass any values to the driver through
ioctl() interface. If the driver doesn't check the value of 'pixclock',
it may cause divide error.

Fix this by checking whether 'pixclock' is zero.

The following log reveals it:
divide error: 0000 [#1] PREEMPT SMP KASAN PTI
RIP: 0010:arkfb_set_par+0x10fc/0x24f0
Call Trace:
<TASK>
fb_set_var+0x604/0xeb0
do_fb_ioctl+0x234/0x670
fb_ioctl+0xdd/0x130
do_syscall_64+0x3b/0x90

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>

authored by

Zheyu Ma and committed by
Helge Deller
e1e96515 16844e58

+3
+3
drivers/video/fbdev/arkfb.c
··· 566 566 { 567 567 int rv, mem, step; 568 568 569 + if (!var->pixclock) 570 + return -EINVAL; 571 + 569 572 /* Find appropriate format */ 570 573 rv = svga_match_format (arkfb_formats, var, NULL); 571 574 if (rv < 0)