Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

can: mcp251x: fix coccinelle warnings

drivers/net/can/spi/mcp251x.c:953:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Make sure threaded IRQs without a primary handler are always request with
IRQF_ONESHOT

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

CC: Stefano Babic <sbabic@denx.de>
CC: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

authored by

Dan Carpenter and committed by
Marc Kleine-Budde
e1dfefeb b6052af6

+1 -1
+1 -1
drivers/net/can/spi/mcp251x.c
··· 951 951 priv->tx_len = 0; 952 952 953 953 ret = request_threaded_irq(spi->irq, NULL, mcp251x_can_ist, 954 - flags, DEVICE_NAME, priv); 954 + flags | IRQF_ONESHOT, DEVICE_NAME, priv); 955 955 if (ret) { 956 956 dev_err(&spi->dev, "failed to acquire irq %d\n", spi->irq); 957 957 mcp251x_power_enable(priv->transceiver, 0);