Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i915/bw: abstract intel_bw_pmdemand_needs_update()

Add intel_bw_pmdemand_needs_update() helper to avoid looking at struct
intel_bw_state internals outside of intel_bw.c.

Reviewed-by: Imre Deak <imre.deak@intel.com>
Link: https://lore.kernel.org/r/163fda39da2e1cf0f0c4fcb9c71103c98863179e.1750847509.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

+17 -5
+14
drivers/gpu/drm/i915/display/intel_bw.c
··· 1651 1651 1652 1652 return 0; 1653 1653 } 1654 + 1655 + bool intel_bw_pmdemand_needs_update(struct intel_atomic_state *state) 1656 + { 1657 + const struct intel_bw_state *new_bw_state, *old_bw_state; 1658 + 1659 + new_bw_state = intel_atomic_get_new_bw_state(state); 1660 + old_bw_state = intel_atomic_get_old_bw_state(state); 1661 + 1662 + if (new_bw_state && 1663 + new_bw_state->qgv_point_peakbw != old_bw_state->qgv_point_peakbw) 1664 + return true; 1665 + 1666 + return false; 1667 + }
+2
drivers/gpu/drm/i915/display/intel_bw.h
··· 76 76 void intel_bw_update_hw_state(struct intel_display *display); 77 77 void intel_bw_crtc_disable_noatomic(struct intel_crtc *crtc); 78 78 79 + bool intel_bw_pmdemand_needs_update(struct intel_atomic_state *state); 80 + 79 81 #endif /* __INTEL_BW_H__ */
+1 -5
drivers/gpu/drm/i915/display/intel_pmdemand.c
··· 294 294 295 295 static bool intel_pmdemand_needs_update(struct intel_atomic_state *state) 296 296 { 297 - const struct intel_bw_state *new_bw_state, *old_bw_state; 298 297 const struct intel_cdclk_state *new_cdclk_state, *old_cdclk_state; 299 298 const struct intel_crtc_state *new_crtc_state, *old_crtc_state; 300 299 struct intel_crtc *crtc; 301 300 int i; 302 301 303 - new_bw_state = intel_atomic_get_new_bw_state(state); 304 - old_bw_state = intel_atomic_get_old_bw_state(state); 305 - if (new_bw_state && new_bw_state->qgv_point_peakbw != 306 - old_bw_state->qgv_point_peakbw) 302 + if (intel_bw_pmdemand_needs_update(state)) 307 303 return true; 308 304 309 305 if (intel_dbuf_pmdemand_needs_update(state))