Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: ltc3651-charger: fix some error codes in probe

There are several cut and past bugs here. ltc3651_charger->charger is
NULL at this point, so we return success instead of the intended error
codes.

Fixes: c94d4ed017ae ("power: supply: Add ltc3651-charger driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
[Wei Yongjun found the same issue independently]
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Mike Looijmans <mike.looijmans@topic.nl>
Signed-off-by: Sebastian Reichel <sre@kernel.org>

authored by

Dan Carpenter and committed by
Sebastian Reichel
e1285417 105df60f

+3 -3
+3 -3
drivers/power/supply/ltc3651-charger.c
··· 110 110 ltc3651_charger->acpr_gpio = devm_gpiod_get(&pdev->dev, 111 111 "lltc,acpr", GPIOD_IN); 112 112 if (IS_ERR(ltc3651_charger->acpr_gpio)) { 113 - ret = PTR_ERR(ltc3651_charger->charger); 113 + ret = PTR_ERR(ltc3651_charger->acpr_gpio); 114 114 dev_err(&pdev->dev, "Failed to acquire acpr GPIO: %d\n", ret); 115 115 return ret; 116 116 } 117 117 ltc3651_charger->fault_gpio = devm_gpiod_get_optional(&pdev->dev, 118 118 "lltc,fault", GPIOD_IN); 119 119 if (IS_ERR(ltc3651_charger->fault_gpio)) { 120 - ret = PTR_ERR(ltc3651_charger->charger); 120 + ret = PTR_ERR(ltc3651_charger->fault_gpio); 121 121 dev_err(&pdev->dev, "Failed to acquire fault GPIO: %d\n", ret); 122 122 return ret; 123 123 } 124 124 ltc3651_charger->chrg_gpio = devm_gpiod_get_optional(&pdev->dev, 125 125 "lltc,chrg", GPIOD_IN); 126 126 if (IS_ERR(ltc3651_charger->chrg_gpio)) { 127 - ret = PTR_ERR(ltc3651_charger->charger); 127 + ret = PTR_ERR(ltc3651_charger->chrg_gpio); 128 128 dev_err(&pdev->dev, "Failed to acquire chrg GPIO: %d\n", ret); 129 129 return ret; 130 130 }