Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

powerpc/powernv: Add a null pointer check in opal_powercap_init()

kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure.

Fixes: b9ef7b4b867f ("powerpc: Convert to using %pOFn instead of device_node.name")
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20231126095739.1501990-1-chentao@kylinos.cn

authored by

Kunwu Chan and committed by
Michael Ellerman
e123015c 8649829a

+6
+6
arch/powerpc/platforms/powernv/opal-powercap.c
··· 196 196 197 197 j = 0; 198 198 pcaps[i].pg.name = kasprintf(GFP_KERNEL, "%pOFn", node); 199 + if (!pcaps[i].pg.name) { 200 + kfree(pcaps[i].pattrs); 201 + kfree(pcaps[i].pg.attrs); 202 + goto out_pcaps_pattrs; 203 + } 204 + 199 205 if (has_min) { 200 206 powercap_add_attr(min, "powercap-min", 201 207 &pcaps[i].pattrs[j]);