Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

xen-netfront, xen-netback: Use correct minimum MTU values

RFC791 specifies the minimum MTU to be 68, while xen-net{front|back}
drivers use a minimum value of 0.

When set MTU to 0~67 with xen_net{front|back} driver, the network
will become unreachable immediately, the guest can no longer be pinged.

xen_net{front|back} should not allow the user to set this value which causes
network problems.

Reported-by: Chen Shi <cheshi@redhat.com>
Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

authored by

Mohammed Gamal and committed by
Boris Ostrovsky
e1043a4b eac779aa

+2 -2
+1 -1
drivers/net/xen-netback/interface.c
··· 486 486 487 487 dev->tx_queue_len = XENVIF_QUEUE_LENGTH; 488 488 489 - dev->min_mtu = 0; 489 + dev->min_mtu = ETH_MIN_MTU; 490 490 dev->max_mtu = ETH_MAX_MTU - VLAN_ETH_HLEN; 491 491 492 492 /*
+1 -1
drivers/net/xen-netfront.c
··· 1316 1316 netdev->features |= netdev->hw_features; 1317 1317 1318 1318 netdev->ethtool_ops = &xennet_ethtool_ops; 1319 - netdev->min_mtu = 0; 1319 + netdev->min_mtu = ETH_MIN_MTU; 1320 1320 netdev->max_mtu = XEN_NETIF_MAX_TX_SIZE; 1321 1321 SET_NETDEV_DEV(netdev, &dev->dev); 1322 1322