Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

crypto: omap-aes - Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Uwe Kleine-König and committed by
Herbert Xu
e0dffa0e a0061b93

+2 -4
+2 -4
drivers/crypto/omap-aes.c
··· 1255 1255 return err; 1256 1256 } 1257 1257 1258 - static int omap_aes_remove(struct platform_device *pdev) 1258 + static void omap_aes_remove(struct platform_device *pdev) 1259 1259 { 1260 1260 struct omap_aes_dev *dd = platform_get_drvdata(pdev); 1261 1261 struct aead_engine_alg *aalg; ··· 1285 1285 pm_runtime_disable(dd->dev); 1286 1286 1287 1287 sysfs_remove_group(&dd->dev->kobj, &omap_aes_attr_group); 1288 - 1289 - return 0; 1290 1288 } 1291 1289 1292 1290 #ifdef CONFIG_PM_SLEEP ··· 1305 1307 1306 1308 static struct platform_driver omap_aes_driver = { 1307 1309 .probe = omap_aes_probe, 1308 - .remove = omap_aes_remove, 1310 + .remove_new = omap_aes_remove, 1309 1311 .driver = { 1310 1312 .name = "omap-aes", 1311 1313 .pm = &omap_aes_pm_ops,