Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net-sysfs: Call dev_hold always in netdev_queue_add_kobject

Dev_hold has to be called always in netdev_queue_add_kobject.
Otherwise usage count drops below 0 in case of failure in
kobject_init_and_add.

Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
Reported-by: Hulk Robot <hulkci@huawei.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: David Miller <davem@davemloft.net>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Jouni Hogander and committed by
David S. Miller
e0b60903 8bef0af0

+5 -2
+5 -2
net/core/net-sysfs.c
··· 1459 1459 struct kobject *kobj = &queue->kobj; 1460 1460 int error = 0; 1461 1461 1462 + /* Kobject_put later will trigger netdev_queue_release call 1463 + * which decreases dev refcount: Take that reference here 1464 + */ 1465 + dev_hold(queue->dev); 1466 + 1462 1467 kobj->kset = dev->queues_kset; 1463 1468 error = kobject_init_and_add(kobj, &netdev_queue_ktype, NULL, 1464 1469 "tx-%u", index); 1465 1470 if (error) 1466 1471 goto err; 1467 - 1468 - dev_hold(queue->dev); 1469 1472 1470 1473 #ifdef CONFIG_BQL 1471 1474 error = sysfs_create_group(kobj, &dql_group);