tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

pinctrl/amd: switch to using a bool for level

The earlier patch can be simplified by using a bool
to indicate level trigger.

Reviewed-by: Pankaj Sen <Pankaj.Sen@amd.com>
Signed-off-by: Nitesh Kumar Agrawal <Nitesh-kumar.Agrawal@amd.com>
[Fixup to earlier manually applied patch]
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Agrawal, Nitesh-kumar and committed by
Linus Walleij e084448b 0eb9f683

+4 -5
+4 -5
drivers/pinctrl/pinctrl-amd.c
··· 403 403 int ret = 0; 404 404 u32 pin_reg; 405 405 unsigned long flags; 406 - u32 level_trig; 406 + bool level_trig; 407 407 u32 active_level; 408 408 struct gpio_chip *gc = irq_data_get_irq_chip_data(d); 409 409 struct amd_gpio *gpio_dev = gpiochip_get_data(gc); ··· 416 416 * default settings, ignore incoming settings from client and use 417 417 * BIOS settings to configure GPIO register. 418 418 */ 419 - level_trig = pin_reg & (LEVEL_TRIGGER << LEVEL_TRIG_OFF); 419 + level_trig = !(pin_reg & (LEVEL_TRIGGER << LEVEL_TRIG_OFF)); 420 420 active_level = pin_reg & (ACTIVE_LEVEL_MASK << ACTIVE_LEVEL_OFF); 421 421 422 - if((!level_trig) && 423 - ((active_level >> ACTIVE_LEVEL_OFF) == ACTIVE_HIGH)) { 422 + if(level_trig && 423 + ((active_level >> ACTIVE_LEVEL_OFF) == ACTIVE_HIGH)) 424 424 type = IRQ_TYPE_EDGE_FALLING; 425 - } 426 425 427 426 switch (type & IRQ_TYPE_SENSE_MASK) { 428 427 case IRQ_TYPE_EDGE_RISING: