Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

netdevsim: remove udp_ports_sleep

Now that there is only one path in udp_tunnel, there is no need to
have udp_ports_sleep knob. Remove it and adjust the test.

Cc: Michael Chan <michael.chan@broadcom.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Stanislav Fomichev <stfomichev@gmail.com>
Link: https://patch.msgid.link/20250616162117.287806-6-stfomichev@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Stanislav Fomichev and committed by
Jakub Kicinski
e054c8ba 3a321b6b

+1 -32
-2
drivers/net/netdevsim/netdevsim.h
··· 131 131 struct nsim_macsec macsec; 132 132 struct { 133 133 u32 inject_error; 134 - u32 sleep; 135 134 u32 __ports[2][NSIM_UDP_TUNNEL_N_PORTS]; 136 135 u32 (*ports)[NSIM_UDP_TUNNEL_N_PORTS]; 137 136 struct dentry *ddir; ··· 341 342 bool ipv4_only; 342 343 bool shared; 343 344 bool static_iana_vxlan; 344 - u32 sleep; 345 345 } udp_ports; 346 346 struct nsim_dev_psample *psample; 347 347 u16 esw_mode;
-8
drivers/net/netdevsim/udp_tunnels.c
··· 18 18 ret = -ns->udp_ports.inject_error; 19 19 ns->udp_ports.inject_error = 0; 20 20 21 - if (ns->udp_ports.sleep) 22 - msleep(ns->udp_ports.sleep); 23 - 24 21 if (!ret) { 25 22 if (ns->udp_ports.ports[table][entry]) { 26 23 WARN(1, "entry already in use\n"); ··· 44 47 ret = -ns->udp_ports.inject_error; 45 48 ns->udp_ports.inject_error = 0; 46 49 47 - if (ns->udp_ports.sleep) 48 - msleep(ns->udp_ports.sleep); 49 50 if (!ret) { 50 51 u32 val = be16_to_cpu(ti->port) << 16 | ti->type; 51 52 ··· 165 170 GFP_KERNEL); 166 171 if (!info) 167 172 return -ENOMEM; 168 - ns->udp_ports.sleep = nsim_dev->udp_ports.sleep; 169 173 170 174 if (nsim_dev->udp_ports.sync_all) { 171 175 info->set_port = NULL; ··· 207 213 &nsim_dev->udp_ports.shared); 208 214 debugfs_create_bool("udp_ports_static_iana_vxlan", 0600, nsim_dev->ddir, 209 215 &nsim_dev->udp_ports.static_iana_vxlan); 210 - debugfs_create_u32("udp_ports_sleep", 0600, nsim_dev->ddir, 211 - &nsim_dev->udp_ports.sleep); 212 216 }
+1 -22
tools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh
··· 266 266 echo $NSIM_ID > /sys/bus/netdevsim/new_device 267 267 else 268 268 echo 1 > $NSIM_DEV_DFS/udp_ports_open_only 269 - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep 270 269 echo 1 > $NSIM_DEV_SYS/new_port 271 270 fi 272 271 NSIM_NETDEV=`get_netdev_name old_netdevs` ··· 349 350 port=0 350 351 echo $NSIM_ID > /sys/bus/netdevsim/new_device 351 352 echo 0 > $NSIM_DEV_SYS/del_port 352 - echo 1000 > $NSIM_DEV_DFS/udp_ports_sleep 353 353 echo 0 > $NSIM_DEV_SYS/new_port 354 354 NSIM_NETDEV=`get_netdev_name old_netdevs` 355 355 356 356 msg="create VxLANs" 357 - exp0=( 0 0 0 0 ) # sleep is longer than out wait 358 - new_vxlan vxlan0 10000 $NSIM_NETDEV 359 - 360 - modprobe -r vxlan 361 - modprobe -r udp_tunnel 362 - 363 - msg="remove tunnels" 364 - exp0=( 0 0 0 0 ) 365 - check_tables 366 - 367 - msg="create VxLANs" 368 - exp0=( 0 0 0 0 ) # sleep is longer than out wait 357 + exp0=( `mke 10000 1` 0 0 0 ) 369 358 new_vxlan vxlan0 10000 $NSIM_NETDEV 370 359 371 360 exp0=( 0 0 0 0 ) ··· 415 428 for port in 0 1; do 416 429 if [ $port -ne 0 ]; then 417 430 echo 1 > $NSIM_DEV_DFS/udp_ports_open_only 418 - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep 419 431 fi 420 432 421 433 echo $port > $NSIM_DEV_SYS/new_port ··· 472 486 for port in 0 1; do 473 487 if [ $port -ne 0 ]; then 474 488 echo 1 > $NSIM_DEV_DFS/udp_ports_open_only 475 - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep 476 489 fi 477 490 478 491 echo $port > $NSIM_DEV_SYS/new_port ··· 528 543 for port in 0 1; do 529 544 if [ $port -ne 0 ]; then 530 545 echo 1 > $NSIM_DEV_DFS/udp_ports_open_only 531 - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep 532 546 fi 533 547 534 548 echo $port > $NSIM_DEV_SYS/new_port ··· 557 573 for port in 0 1; do 558 574 if [ $port -ne 0 ]; then 559 575 echo 1 > $NSIM_DEV_DFS/udp_ports_open_only 560 - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep 561 576 fi 562 577 563 578 echo $port > $NSIM_DEV_SYS/new_port ··· 617 634 for port in 0 1; do 618 635 if [ $port -ne 0 ]; then 619 636 echo 1 > $NSIM_DEV_DFS/udp_ports_open_only 620 - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep 621 637 fi 622 638 623 639 echo $port > $NSIM_DEV_SYS/new_port ··· 672 690 for port in 0 1; do 673 691 if [ $port -ne 0 ]; then 674 692 echo 1 > $NSIM_DEV_DFS/udp_ports_open_only 675 - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep 676 693 fi 677 694 678 695 echo $port > $NSIM_DEV_SYS/new_port ··· 731 750 for port in 0 1; do 732 751 if [ $port -ne 0 ]; then 733 752 echo 1 > $NSIM_DEV_DFS/udp_ports_open_only 734 - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep 735 753 fi 736 754 737 755 echo $port > $NSIM_DEV_SYS/new_port ··· 789 809 echo 0 > $NSIM_DEV_SYS/del_port 790 810 791 811 echo 0 > $NSIM_DEV_DFS/udp_ports_open_only 792 - echo 1 > $NSIM_DEV_DFS/udp_ports_sleep 793 812 echo 1 > $NSIM_DEV_DFS/udp_ports_shared 794 813 795 814 old_netdevs=$(ls /sys/class/net)