Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fpga: m10bmc-sec: Fix kconfig dependencies

The secure update driver depends on the firmware-upload functionality of
the firmware-loader. The firmware-loader is carried in the firmware-class
driver which is enabled with the tristate CONFIG_FW_LOADER option. The
firmware-upload functionality is included in the firmware-class driver if
the bool FW_UPLOAD config is set.

The current dependency statement, "depends on FW_UPLOAD", is not adequate
because it does not implicitly turn on FW_LOADER. Instead of adding a
dependency, follow the convention used by drivers that require the
FW_LOADER_USER_HELPER functionality of the firmware-loader by using
select for both FW_LOADER and FW_UPLOAD.

Fixes: bdf86d0e6ca3 ("fpga: m10bmc-sec: create max10 bmc secure update")
Reported-by: kernel test robot <lkp@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Russ Weight <russell.h.weight@intel.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20221115001127.289890-1-russell.h.weight@intel.com
Signed-off-by: Xu Yilun <yilun.xu@intel.com>

authored by

Russ Weight and committed by
Xu Yilun
dfd10332 9abf2313

+3 -1
+3 -1
drivers/fpga/Kconfig
··· 246 246 247 247 config FPGA_M10_BMC_SEC_UPDATE 248 248 tristate "Intel MAX10 BMC Secure Update driver" 249 - depends on MFD_INTEL_M10_BMC && FW_UPLOAD 249 + depends on MFD_INTEL_M10_BMC 250 + select FW_LOADER 251 + select FW_UPLOAD 250 252 help 251 253 Secure update support for the Intel MAX10 board management 252 254 controller.